All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: linux-fbdev@vger.kernel.org
Subject: Kill ->fb_rotate?
Date: Wed, 20 Jan 2016 21:16:43 +0000	[thread overview]
Message-ID: <87d1swdk90.fsf@rasmusvillemoes.dk> (raw)

Hi,

it seems that the fb_rotate method in struct fb_ops is never actually
invoked, and it's been that way in the entire history of git (in fact,
the last occurrence of the string '->fb_rotate' vanished over 10 years
ago, with b4d8aea6d6). Is there any reason not to nuke the few dozen
lines of dead code in the few drivers that actually implement it and
reduce sizeof(struct fb_ops) by sizeof(void*)?

Rasmus

             reply	other threads:[~2016-01-20 21:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-20 21:16 Rasmus Villemoes [this message]
2016-02-09 18:56 ` [PATCH] fbdev: kill fb_rotate Rasmus Villemoes
2016-02-09 18:56   ` Rasmus Villemoes
2016-02-26 11:30   ` Tomi Valkeinen
2016-02-26 11:30     ` Tomi Valkeinen
2016-02-26 11:30     ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d1swdk90.fsf@rasmusvillemoes.dk \
    --to=linux@rasmusvillemoes.dk \
    --cc=linux-fbdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.