From: Kalle Valo <kvalo@codeaurora.org>
To: David Lin <dlin@marvell.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
"linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>,
"Chor Teck Law" <ctlaw@marvell.com>,
Pete Hsieh <peteh@marvell.com>
Subject: Re: [PATCH v7] Add new mac80211 driver mwlwifi.
Date: Thu, 10 Dec 2015 16:57:59 +0200 [thread overview]
Message-ID: <87d1ue73m0.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <9d111cc7d61047b5890b7c5d53d71bbd@SC-EXCH02.marvell.com> (David Lin's message of "Fri, 27 Nov 2015 02:00:00 +0000")
David Lin <dlin@marvell.com> writes:
> On November 26, 2015 5:40 PM, Johannes Berg wrote:
>> On Thu, 2015-11-26 at 08:27 +0000, David Lin wrote:
>>
>> > > > +#ifdef CONFIG_SUPPORT_MFG
>> > >
>> > > This Kconfig variable doesn't exist.
>> > >
>> >
>> > The compile variable is used privately by Marvell and our customers in
>> > production line.
>>
>> Yeah, still. Make it a proper Kconfig variable, defaulting to off and hidden
>> under something, or remove it. It's extremely misleading to have something
>> called CONFIG_* when it's not a Kconfig variable.
>>
>
> I will change this compile variable from "CONFIG_SUPPORT_MFG" to
> "SUPPORT_MFG".
Then it's still dead code which won't ever get compiled in upstream.
Please follow what Johannes suggested.
--
Kalle Valo
next prev parent reply other threads:[~2015-12-10 14:58 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 3:51 [PATCH v7] Add new mac80211 driver mwlwifi David Lin
2015-11-12 19:47 ` Jes Sorensen
2015-11-26 8:34 ` David Lin
2015-11-20 11:22 ` Johannes Berg
2015-11-26 8:27 ` David Lin
2015-11-26 9:40 ` Johannes Berg
2015-11-27 2:00 ` David Lin
2015-11-27 8:27 ` Johannes Berg
2015-12-10 14:57 ` Kalle Valo [this message]
2015-12-15 7:54 ` David Lin
2015-12-10 14:06 ` Kalle Valo
[not found] ` <CANEJEGv7ENTJu4YHz1x2_ve2M6-3Nn8X-0aC2hA3o1mUs3tQ1g@mail.gmail.com>
2015-12-12 0:47 ` Grant Grundler
2015-12-14 11:47 ` Kalle Valo
2015-12-10 14:03 ` Kalle Valo
2015-12-10 14:39 ` Kalle Valo
2015-12-15 7:55 ` David Lin
2015-12-14 21:32 ` Kan Yan
2015-12-15 5:47 ` David Lin
2015-12-15 7:40 ` Emmanuel Grumbach
2015-12-15 7:53 ` David Lin
2016-03-16 23:24 ` Julian Calaby
2016-03-17 1:23 ` David Lin
2016-03-17 1:32 ` Julian Calaby
2016-03-17 2:10 ` David Lin
2016-04-03 12:05 ` Bjørn Mork
2016-04-15 12:40 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1ue73m0.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=ctlaw@marvell.com \
--cc=dlin@marvell.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=peteh@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.