From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50316)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1a0u1l-0001KX-9r
	for qemu-devel@nongnu.org; Mon, 23 Nov 2015 11:31:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1a0u1k-0003eR-Jh
	for qemu-devel@nongnu.org; Mon, 23 Nov 2015 11:31:41 -0500
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <564EE9C9.6000707@cn.fujitsu.com> (Wen Congyang's message of
	"Fri, 20 Nov 2015 17:37:13 +0800")
References: <564EE9C9.6000707@cn.fujitsu.com>
Date: Mon, 23 Nov 2015 17:31:33 +0100
Message-ID: <87d1v0isnu.fsf@emacs.mitica>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH for-2.5] block-migration: limit the memory
	usage
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wen Congyang <wency@cn.fujitsu.com>
Cc: Amit Shah <amit.shah@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, qemu-devl <qemu-devel@nongnu.org>, qemu block <qemu-block@nongnu.org>

Wen Congyang <wency@cn.fujitsu.com> wrote:
> If we set migration speed in a very large value, block-migration will try to read
> all data to the memory. Because
>     (block_mig_state.submitted + block_mig_state.read_done) * BLOCK_SIZE
> will be overflow, and it will be always less than rate limit.
>
> There is no need to read too many data into memory when the rate limit is very large.
> So limit the memory usage can fix the overflow problem.
>
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>

If no block layer maintainer objects, I will apply this to my tree.

Later, Juan.