From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46848) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvilT-0001L5-DX for qemu-devel@nongnu.org; Mon, 09 Nov 2015 04:29:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZvilQ-0005V5-Kh for qemu-devel@nongnu.org; Mon, 09 Nov 2015 04:29:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55936) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvilQ-0005V0-Fv for qemu-devel@nongnu.org; Mon, 09 Nov 2015 04:29:24 -0500 From: Juan Quintela In-Reply-To: <1446747083-18205-13-git-send-email-dgilbert@redhat.com> (David Alan Gilbert's message of "Thu, 5 Nov 2015 18:10:39 +0000") References: <1446747083-18205-1-git-send-email-dgilbert@redhat.com> <1446747083-18205-13-git-send-email-dgilbert@redhat.com> Date: Mon, 09 Nov 2015 10:29:21 +0100 Message-ID: <87d1vjed1q.fsf@emacs.mitica> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v9 12/56] ram_load: Factor out host_from_stream_offset call and check Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, liang.z.li@intel.com, qemu-devel@nongnu.org, luis@cs.umu.se, bharata@linux.vnet.ibm.com, amit.shah@redhat.com, pbonzini@redhat.com, david@gibson.dropbear.id.au "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > The main RAM load loop has a call to host_from_stream_offset for > each page type that actually loads data with the same test; > factor it out before the switch. > > The host = NULL is to silence a bogus gcc warning of > an unitialised in the RAM_SAVE_COMPRESS_PAGE case, it > doesn't seem to realise that host is always initialised by the if at > the top in the cases the switch takes. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela