From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm: Use userspace compatible type in fourcc_mod_code macro Date: Thu, 05 Nov 2015 14:51:22 +0200 Message-ID: <87d1vomwxh.fsf@intel.com> References: <1442999431-28568-1-git-send-email-tvrtko.ursulin@linux.intel.com> <20150923113642.GY26517@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20150923113642.GY26517@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?utf-8?B?U3lyasOkbMOk?= , Tvrtko Ursulin Cc: Daniel Vetter , Intel-gfx@lists.freedesktop.org, stable@vger.kernel.org, Daniel Stone , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCAyMyBTZXAgMjAxNSwgVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4 LmludGVsLmNvbT4gd3JvdGU6Cj4gT24gV2VkLCBTZXAgMjMsIDIwMTUgYXQgMTA6MTA6MzFBTSAr MDEwMCwgVHZydGtvIFVyc3VsaW4gd3JvdGU6Cj4+IEZyb206IFR2cnRrbyBVcnN1bGluIDx0dnJ0 a28udXJzdWxpbkBpbnRlbC5jb20+Cj4+IAo+PiBfX3U2NCBzaG91bGQgYmUgdXNlZCBpbnN0ZWFk IG9mIHU2NC4KPj4gCj4+IEZlYXR1cmUgb3JpZ2luYWxseSBhZGRlZCBpbjoKPj4gCj4+IGNvbW1p dCBlM2ViMzI1MGQ4NGVmOTdiNzY2MzEyMzQ1Nzc0MzY3YjZhMzEwZGI4Cj4+IEF1dGhvcjogUm9i IENsYXJrIDxyb2JkY2xhcmtAZ21haWwuY29tPgo+PiBEYXRlOiAgIFRodSBGZWIgNSAxNDo0MTo1 MiAyMDE1ICswMDAwCj4+IAo+PiAgICAgZHJtOiBhZGQgc3VwcG9ydCBmb3IgdGlsZWQvY29tcHJl c3NlZC9ldGMgbW9kaWZpZXIgaW4gYWRkZmIyCj4+IAo+PiBTaWduZWQtb2ZmLWJ5OiBUdnJ0a28g VXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+PiBDYzogUm9iIENsYXJrIDxyb2Jk Y2xhcmtAZ21haWwuY29tPgo+PiBDYzogRGFuaWVsIFN0b25lIDxkYW5pZWxzQGNvbGxhYm9yYS5j b20+Cj4+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGludGVsLmNvbT4KPj4gQ2M6 IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPj4gQ2M6IHN0YWJsZUB2Z2VyLmtlcm5l bC5vcmcKPgo+IFJldmlld2VkLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGlu dXguaW50ZWwuY29tPgoKUHVzaGVkIHRvIG91ciB0b3BpYy9kcm0tZml4ZXMgYnJhbmNoLCB0aGFu a3MgZm9yIHRoZSBwYXRjaCBhbmQgcmV2aWV3LgoKQlIsCkphbmkuCgo+Cj4+IC0tLQo+PiAgaW5j bHVkZS91YXBpL2RybS9kcm1fZm91cmNjLmggfCAyICstCj4+ICAxIGZpbGUgY2hhbmdlZCwgMSBp bnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKPj4gCj4+IGRpZmYgLS1naXQgYS9pbmNsdWRlL3Vh cGkvZHJtL2RybV9mb3VyY2MuaCBiL2luY2x1ZGUvdWFwaS9kcm0vZHJtX2ZvdXJjYy5oCj4+IGlu ZGV4IDhjNWU4YjkxYTNjYi4uMGI2OWE3NzUzNTU4IDEwMDY0NAo+PiAtLS0gYS9pbmNsdWRlL3Vh cGkvZHJtL2RybV9mb3VyY2MuaAo+PiArKysgYi9pbmNsdWRlL3VhcGkvZHJtL2RybV9mb3VyY2Mu aAo+PiBAQCAtMTU4LDcgKzE1OCw3IEBACj4+ICAvKiBhZGQgbW9yZSB0byB0aGUgZW5kIGFzIG5l ZWRlZCAqLwo+PiAgCj4+ICAjZGVmaW5lIGZvdXJjY19tb2RfY29kZSh2ZW5kb3IsIHZhbCkgXAo+ PiAtCSgoKCh1NjQpRFJNX0ZPUk1BVF9NT0RfVkVORE9SXyMjIHZlbmRvcikgPDwgNTYpIHwgKHZh bCAmIDB4MDBmZmZmZmZmZmZmZmZmZlVMTCkpCj4+ICsJKCgoKF9fdTY0KURSTV9GT1JNQVRfTU9E X1ZFTkRPUl8jIyB2ZW5kb3IpIDw8IDU2KSB8ICh2YWwgJiAweDAwZmZmZmZmZmZmZmZmZmZVTEwp KQo+PiAgCj4+ICAvKgo+PiAgICogRm9ybWF0IE1vZGlmaWVyIHRva2VuczoKPj4gLS0gCj4+IDIu NS4xCj4+IAo+PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Xwo+PiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKPj4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu dGVsLWdmeAoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENl bnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRl bC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com ([134.134.136.65]:41689 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161132AbbKEMru convert rfc822-to-8bit (ORCPT ); Thu, 5 Nov 2015 07:47:50 -0500 From: Jani Nikula To: Ville =?utf-8?B?U3lyasOkbMOk?= , Tvrtko Ursulin Cc: dri-devel@lists.freedesktop.org, Daniel Vetter , Intel-gfx@lists.freedesktop.org, Daniel Stone , stable@vger.kernel.org Subject: Re: [Intel-gfx] [PATCH] drm: Use userspace compatible type in fourcc_mod_code macro In-Reply-To: <20150923113642.GY26517@intel.com> References: <1442999431-28568-1-git-send-email-tvrtko.ursulin@linux.intel.com> <20150923113642.GY26517@intel.com> Date: Thu, 05 Nov 2015 14:51:22 +0200 Message-ID: <87d1vomwxh.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: stable-owner@vger.kernel.org List-ID: On Wed, 23 Sep 2015, Ville Syrjälä wrote: > On Wed, Sep 23, 2015 at 10:10:31AM +0100, Tvrtko Ursulin wrote: >> From: Tvrtko Ursulin >> >> __u64 should be used instead of u64. >> >> Feature originally added in: >> >> commit e3eb3250d84ef97b766312345774367b6a310db8 >> Author: Rob Clark >> Date: Thu Feb 5 14:41:52 2015 +0000 >> >> drm: add support for tiled/compressed/etc modifier in addfb2 >> >> Signed-off-by: Tvrtko Ursulin >> Cc: Rob Clark >> Cc: Daniel Stone >> Cc: Daniel Vetter >> Cc: dri-devel@lists.freedesktop.org >> Cc: stable@vger.kernel.org > > Reviewed-by: Ville Syrjälä Pushed to our topic/drm-fixes branch, thanks for the patch and review. BR, Jani. > >> --- >> include/uapi/drm/drm_fourcc.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h >> index 8c5e8b91a3cb..0b69a7753558 100644 >> --- a/include/uapi/drm/drm_fourcc.h >> +++ b/include/uapi/drm/drm_fourcc.h >> @@ -158,7 +158,7 @@ >> /* add more to the end as needed */ >> >> #define fourcc_mod_code(vendor, val) \ >> - ((((u64)DRM_FORMAT_MOD_VENDOR_## vendor) << 56) | (val & 0x00ffffffffffffffULL)) >> + ((((__u64)DRM_FORMAT_MOD_VENDOR_## vendor) << 56) | (val & 0x00ffffffffffffffULL)) >> >> /* >> * Format Modifier tokens: >> -- >> 2.5.1 >> >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center