From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47510)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZXX8V-0005Cy-UB
	for qemu-devel@nongnu.org; Thu, 03 Sep 2015 12:13:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZXX8S-0006qF-Oy
	for qemu-devel@nongnu.org; Thu, 03 Sep 2015 12:13:15 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59443)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZXX8S-0006qB-Ju
	for qemu-devel@nongnu.org; Thu, 03 Sep 2015 12:13:12 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1438703896-12553-1-git-send-email-armbru@redhat.com>
	<1438703896-12553-3-git-send-email-armbru@redhat.com>
	<55C1343F.5060003@redhat.com> <87io8uuuc7.fsf@blackfin.pond.sub.org>
	<55C21D6D.2080106@redhat.com> <87mvy5j7ek.fsf@blackfin.pond.sub.org>
	<87y4gre3d7.fsf@blackfin.pond.sub.org> <55E85E9D.9020700@redhat.com>
Date: Thu, 03 Sep 2015 18:13:10 +0200
In-Reply-To: <55E85E9D.9020700@redhat.com> (Eric Blake's message of "Thu, 3
	Sep 2015 08:52:13 -0600")
Message-ID: <87d1xzo50p.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH RFC v3 02/32] qapi: New QAPISchema
	intermediate reperesentation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, berto@igalia.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com

Eric Blake <eblake@redhat.com> writes:

> On 08/31/2015 12:09 PM, Markus Armbruster wrote:
>
>>>>>>
>>>>>> since we don't allow 2D arrays?
>>>>>
>>>>> If the generators actually rely on it, yes.
>
>> The appended experimental frontend patch passes "make check".  Looks
>> like the backends are just fine with arrays of arrays.  I'll therefore
>> refrain from adding "element type isn't array" assertions to backends.
>> 
>> Since there's plenty of QAPI work on list already, I'll shelve this
>> patch for now.  We can revisit nested arrays later.
>
> Another thing to think about if we allow nested arrays: patch 31/32 maps
> 'uint8' to 'int', and ['uint8'] to ['int'], but leaves [['uint8']]
> untouched.  We'd have to add a while loop in qapi-introspect.py to
> ensure we drill down through all levels of an array.

Yes, that's broken in my experimental patch.