From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 1/2] drm/i915: Read sink_count dpcd always for short hpd Date: Mon, 17 Aug 2015 15:09:56 +0300 Message-ID: <87d1ymnmjv.fsf@intel.com> References: <1439811096-13561-1-git-send-email-sivakumar.thulasimani@intel.com> <1439811096-13561-2-git-send-email-sivakumar.thulasimani@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id E1CEC6E8ED for ; Mon, 17 Aug 2015 05:06:57 -0700 (PDT) In-Reply-To: <1439811096-13561-2-git-send-email-sivakumar.thulasimani@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Sivakumar Thulasimani , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCAxNyBBdWcgMjAxNSwgU2l2YWt1bWFyIFRodWxhc2ltYW5pIDxzaXZha3VtYXIudGh1 bGFzaW1hbmlAaW50ZWwuY29tPiB3cm90ZToKPiBGcm9tOiAiVGh1bGFzaW1hbmksU2l2YWt1bWFy IiA8c2l2YWt1bWFyLnRodWxhc2ltYW5pQGludGVsLmNvbT4KPgo+IENvbXBsaWFuY2UgdGVzdCA0 LjIuMi44IHJlcXVpcmVzIGRyaXZlciB0byByZWFkIHRoZSBzaW5rX2NvdW50IGZvcgo+IHNob3J0 IHB1bHNlIGludGVycnVwdCBldmVuIHdoZW4gdGhlIHBhbmVsIGlzIG5vdCBlbmFibGVkLgo+IFRo aXMgcGF0Y2ggcGVyZm9ybXMgdGhlIGZvbGxvd2luZwo+IGEpIHJlYWRpbmcgc2lua19jb3VudCBi eSByZXVzaW5nIGludGVsX2RwX2RldGVjdF9kcGNkCj4gaW5zdGVhZCBvZiB1c2luZyBpbnRlbF9k cF9nZXRfZHBjZAo+IGIpIG1vdmluZyBjcnRjIGVuYWJsZWQgY2hlY2tzIHBvc3Qgc2lua19jb3Vu dCByZWFkIGNhbGwKPgo+IFNpZ25lZC1vZmYtYnk6IFNpdmFrdW1hciBUaHVsYXNpbWFuaSA8c2l2 YWt1bWFyLnRodWxhc2ltYW5pQGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZHAuYyB8ICAxMTcgKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0t LS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA1OSBpbnNlcnRpb25zKCspLCA1OCBkZWxldGlvbnMoLSkK Pgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+IGluZGV4IGI5MDVjMTkuLmU0ZGU4ZTUgMTAwNjQ0 Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiBAQCAtNDM0Miw2ICs0MzQyLDU2IEBAIGdvX2FnYWlu Ogo+ICAJcmV0dXJuIC1FSU5WQUw7Cj4gIH0KPiAgCj4gKy8qIFhYWCB0aGlzIGlzIHByb2JhYmx5 IHdyb25nIGZvciBtdWx0aXBsZSBkb3duc3RyZWFtIHBvcnRzICovCj4gK3N0YXRpYyBlbnVtIGRy bV9jb25uZWN0b3Jfc3RhdHVzCj4gK2ludGVsX2RwX2RldGVjdF9kcGNkKHN0cnVjdCBpbnRlbF9k cCAqaW50ZWxfZHApCj4gK3sKPiArCXVpbnQ4X3QgKmRwY2QgPSBpbnRlbF9kcC0+ZHBjZDsKPiAr CXVpbnQ4X3QgdHlwZTsKPiArCj4gKwlpZiAoIWludGVsX2RwX2dldF9kcGNkKGludGVsX2RwKSkK PiArCQlyZXR1cm4gY29ubmVjdG9yX3N0YXR1c19kaXNjb25uZWN0ZWQ7Cj4gKwo+ICsJLyogaWYg dGhlcmUncyBubyBkb3duc3RyZWFtIHBvcnQsIHdlJ3JlIGRvbmUgKi8KPiArCWlmICghKGRwY2Rb RFBfRE9XTlNUUkVBTVBPUlRfUFJFU0VOVF0gJiBEUF9EV05fU1RSTV9QT1JUX1BSRVNFTlQpKQo+ ICsJCXJldHVybiBjb25uZWN0b3Jfc3RhdHVzX2Nvbm5lY3RlZDsKPiArCj4gKwkvKiBJZiB3ZSdy ZSBIUEQtYXdhcmUsIFNJTktfQ09VTlQgY2hhbmdlcyBkeW5hbWljYWxseSAqLwo+ICsJaWYgKGlu dGVsX2RwLT5kcGNkW0RQX0RQQ0RfUkVWXSA+PSAweDExICYmCj4gKwkgICAgaW50ZWxfZHAtPmRv d25zdHJlYW1fcG9ydHNbMF0gJiBEUF9EU19QT1JUX0hQRCkgewo+ICsJCXVpbnQ4X3QgcmVnOwo+ ICsKPiArCQlpZiAoaW50ZWxfZHBfZHBjZF9yZWFkX3dha2UoJmludGVsX2RwLT5hdXgsIERQX1NJ TktfQ09VTlQsCj4gKwkJCQkJICAgICZyZWcsIDEpIDwgMCkKPiArCQkJcmV0dXJuIGNvbm5lY3Rv cl9zdGF0dXNfdW5rbm93bjsKPiArCj4gKwkJcmV0dXJuIERQX0dFVF9TSU5LX0NPVU5UKHJlZykg PyBjb25uZWN0b3Jfc3RhdHVzX2Nvbm5lY3RlZAo+ICsJCQkJCSAgICAgIDogY29ubmVjdG9yX3N0 YXR1c19kaXNjb25uZWN0ZWQ7Cj4gKwl9Cj4gKwo+ICsJLyogSWYgbm8gSFBELCBwb2tlIEREQyBn ZW50bHkgKi8KPiArCWlmIChkcm1fcHJvYmVfZGRjKCZpbnRlbF9kcC0+YXV4LmRkYykpCj4gKwkJ cmV0dXJuIGNvbm5lY3Rvcl9zdGF0dXNfY29ubmVjdGVkOwo+ICsKPiArCS8qIFdlbGwgd2UgdHJp ZWQsIHNheSB1bmtub3duIGZvciB1bnJlbGlhYmxlIHBvcnQgdHlwZXMgKi8KPiArCWlmIChpbnRl bF9kcC0+ZHBjZFtEUF9EUENEX1JFVl0gPj0gMHgxMSkgewo+ICsJCXR5cGUgPSBpbnRlbF9kcC0+ ZG93bnN0cmVhbV9wb3J0c1swXSAmIERQX0RTX1BPUlRfVFlQRV9NQVNLOwo+ICsJCWlmICh0eXBl ID09IERQX0RTX1BPUlRfVFlQRV9WR0EgfHwKPiArCQkgICAgdHlwZSA9PSBEUF9EU19QT1JUX1RZ UEVfTk9OX0VESUQpCj4gKwkJCXJldHVybiBjb25uZWN0b3Jfc3RhdHVzX3Vua25vd247Cj4gKwl9 IGVsc2Ugewo+ICsJCXR5cGUgPSBpbnRlbF9kcC0+ZHBjZFtEUF9ET1dOU1RSRUFNUE9SVF9QUkVT RU5UXSAmCj4gKwkJCURQX0RXTl9TVFJNX1BPUlRfVFlQRV9NQVNLOwo+ICsJCWlmICh0eXBlID09 IERQX0RXTl9TVFJNX1BPUlRfVFlQRV9BTkFMT0cgfHwKPiArCQkgICAgdHlwZSA9PSBEUF9EV05f U1RSTV9QT1JUX1RZUEVfT1RIRVIpCj4gKwkJCXJldHVybiBjb25uZWN0b3Jfc3RhdHVzX3Vua25v d247Cj4gKwl9Cj4gKwo+ICsJLyogQW55dGhpbmcgZWxzZSBpcyBvdXQgb2Ygc3BlYywgd2FybiBh bmQgaWdub3JlICovCj4gKwlEUk1fREVCVUdfS01TKCJCcm9rZW4gRFAgYnJhbmNoIGRldmljZSwg aWdub3JpbmdcbiIpOwo+ICsJcmV0dXJuIGNvbm5lY3Rvcl9zdGF0dXNfZGlzY29ubmVjdGVkOwo+ ICt9CgpQbGVhc2UgZWl0aGVyIGEpIGp1c3QgYWRkIGEgZm9yd2FyZCBkZWNsYXJhdGlvbiBmb3IK aW50ZWxfZHBfZGV0ZWN0X2RwY2QsIG9yIGIpIGFkZCBhIHNlcGFyYXRlIG5vbi1mdW5jdGlvbmFs IHByZXAgcGF0Y2gKdGhhdCBtb3ZlcyB0aGUgZnVuY3Rpb24gYXJvdW5kLiBQbGVhc2UgZG9uJ3Qg Y29tYmluZSBjb2RlIG1vdmVtZW50IHdpdGgKZnVuY3Rpb25hbCBjaGFuZ2VzLgoKQlIsCkphbmku CgoKPiArCj4gIC8qCj4gICAqIEFjY29yZGluZyB0byBEUCBzcGVjCj4gICAqIDUuMS4yOgo+IEBA IC00MzYyLDIxICs0NDEyLDIyIEBAIGludGVsX2RwX2NoZWNrX2xpbmtfc3RhdHVzKHN0cnVjdCBp bnRlbF9kcCAqaW50ZWxfZHApCj4gIAo+ICAJV0FSTl9PTighZHJtX21vZGVzZXRfaXNfbG9ja2Vk KCZkZXYtPm1vZGVfY29uZmlnLmNvbm5lY3Rpb25fbXV0ZXgpKTsKPiAgCj4gLQlpZiAoIWludGVs X2VuY29kZXItPmJhc2UuY3J0YykKPiArCS8qIDQuMi4yLjggcmVxdWlyZXMgc291cmNlIHRvIHJl YWQgbGlua19zdGF0dXMsIDAgLSAxMiBEUENEICYKPiArCSAqIHNpbmtfY291bnQgZXZlbiBmb3Ig c2hvcnQgcHVsc2UgaXJyZXNwZWN0aXZlIG9mIHRoZSBzaW5rIGlzCj4gKwkgKiBpbiB1c2Ugb3Ig bm90Cj4gKwkgKi8KPiArCWlmICghaW50ZWxfZHBfZ2V0X2xpbmtfc3RhdHVzKGludGVsX2RwLCBs aW5rX3N0YXR1cykpCj4gIAkJcmV0dXJuOwo+ICAKPiAtCWlmICghdG9faW50ZWxfY3J0YyhpbnRl bF9lbmNvZGVyLT5iYXNlLmNydGMpLT5hY3RpdmUpCj4gKwkvKiByZXVzZSB0byByZWFkIGJvdGgg MCAtIDEyIERQQ0QgJiBzaW5rX2NvdW50ICovCj4gKwlpZiAoaW50ZWxfZHBfZGV0ZWN0X2RwY2Qo aW50ZWxfZHApICE9IGNvbm5lY3Rvcl9zdGF0dXNfY29ubmVjdGVkKQo+ICAJCXJldHVybjsKPiAg Cj4gLQkvKiBUcnkgdG8gcmVhZCByZWNlaXZlciBzdGF0dXMgaWYgdGhlIGxpbmsgYXBwZWFycyB0 byBiZSB1cCAqLwo+IC0JaWYgKCFpbnRlbF9kcF9nZXRfbGlua19zdGF0dXMoaW50ZWxfZHAsIGxp bmtfc3RhdHVzKSkgewo+ICsJaWYgKCFpbnRlbF9lbmNvZGVyLT5iYXNlLmNydGMpCj4gIAkJcmV0 dXJuOwo+IC0JfQo+ICAKPiAtCS8qIE5vdyByZWFkIHRoZSBEUENEIHRvIHNlZSBpZiBpdCdzIGFj dHVhbGx5IHJ1bm5pbmcgKi8KPiAtCWlmICghaW50ZWxfZHBfZ2V0X2RwY2QoaW50ZWxfZHApKSB7 Cj4gKwlpZiAoIXRvX2ludGVsX2NydGMoaW50ZWxfZW5jb2Rlci0+YmFzZS5jcnRjKS0+YWN0aXZl KQo+ICAJCXJldHVybjsKPiAtCX0KPiAgCj4gIAkvKiBUcnkgdG8gcmVhZCB0aGUgc291cmNlIG9m IHRoZSBpbnRlcnJ1cHQgKi8KPiAgCWlmIChpbnRlbF9kcC0+ZHBjZFtEUF9EUENEX1JFVl0gPj0g MHgxMSAmJgo+IEBAIC00NDAxLDU2ICs0NDUyLDYgQEAgaW50ZWxfZHBfY2hlY2tfbGlua19zdGF0 dXMoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPiAgCX0KPiAgfQo+ICAKPiAtLyogWFhYIHRo aXMgaXMgcHJvYmFibHkgd3JvbmcgZm9yIG11bHRpcGxlIGRvd25zdHJlYW0gcG9ydHMgKi8KPiAt c3RhdGljIGVudW0gZHJtX2Nvbm5lY3Rvcl9zdGF0dXMKPiAtaW50ZWxfZHBfZGV0ZWN0X2RwY2Qo c3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPiAtewo+IC0JdWludDhfdCAqZHBjZCA9IGludGVs X2RwLT5kcGNkOwo+IC0JdWludDhfdCB0eXBlOwo+IC0KPiAtCWlmICghaW50ZWxfZHBfZ2V0X2Rw Y2QoaW50ZWxfZHApKQo+IC0JCXJldHVybiBjb25uZWN0b3Jfc3RhdHVzX2Rpc2Nvbm5lY3RlZDsK PiAtCj4gLQkvKiBpZiB0aGVyZSdzIG5vIGRvd25zdHJlYW0gcG9ydCwgd2UncmUgZG9uZSAqLwo+ IC0JaWYgKCEoZHBjZFtEUF9ET1dOU1RSRUFNUE9SVF9QUkVTRU5UXSAmIERQX0RXTl9TVFJNX1BP UlRfUFJFU0VOVCkpCj4gLQkJcmV0dXJuIGNvbm5lY3Rvcl9zdGF0dXNfY29ubmVjdGVkOwo+IC0K PiAtCS8qIElmIHdlJ3JlIEhQRC1hd2FyZSwgU0lOS19DT1VOVCBjaGFuZ2VzIGR5bmFtaWNhbGx5 ICovCj4gLQlpZiAoaW50ZWxfZHAtPmRwY2RbRFBfRFBDRF9SRVZdID49IDB4MTEgJiYKPiAtCSAg ICBpbnRlbF9kcC0+ZG93bnN0cmVhbV9wb3J0c1swXSAmIERQX0RTX1BPUlRfSFBEKSB7Cj4gLQkJ dWludDhfdCByZWc7Cj4gLQo+IC0JCWlmIChpbnRlbF9kcF9kcGNkX3JlYWRfd2FrZSgmaW50ZWxf ZHAtPmF1eCwgRFBfU0lOS19DT1VOVCwKPiAtCQkJCQkgICAgJnJlZywgMSkgPCAwKQo+IC0JCQly ZXR1cm4gY29ubmVjdG9yX3N0YXR1c191bmtub3duOwo+IC0KPiAtCQlyZXR1cm4gRFBfR0VUX1NJ TktfQ09VTlQocmVnKSA/IGNvbm5lY3Rvcl9zdGF0dXNfY29ubmVjdGVkCj4gLQkJCQkJICAgICAg OiBjb25uZWN0b3Jfc3RhdHVzX2Rpc2Nvbm5lY3RlZDsKPiAtCX0KPiAtCj4gLQkvKiBJZiBubyBI UEQsIHBva2UgRERDIGdlbnRseSAqLwo+IC0JaWYgKGRybV9wcm9iZV9kZGMoJmludGVsX2RwLT5h dXguZGRjKSkKPiAtCQlyZXR1cm4gY29ubmVjdG9yX3N0YXR1c19jb25uZWN0ZWQ7Cj4gLQo+IC0J LyogV2VsbCB3ZSB0cmllZCwgc2F5IHVua25vd24gZm9yIHVucmVsaWFibGUgcG9ydCB0eXBlcyAq Lwo+IC0JaWYgKGludGVsX2RwLT5kcGNkW0RQX0RQQ0RfUkVWXSA+PSAweDExKSB7Cj4gLQkJdHlw ZSA9IGludGVsX2RwLT5kb3duc3RyZWFtX3BvcnRzWzBdICYgRFBfRFNfUE9SVF9UWVBFX01BU0s7 Cj4gLQkJaWYgKHR5cGUgPT0gRFBfRFNfUE9SVF9UWVBFX1ZHQSB8fAo+IC0JCSAgICB0eXBlID09 IERQX0RTX1BPUlRfVFlQRV9OT05fRURJRCkKPiAtCQkJcmV0dXJuIGNvbm5lY3Rvcl9zdGF0dXNf dW5rbm93bjsKPiAtCX0gZWxzZSB7Cj4gLQkJdHlwZSA9IGludGVsX2RwLT5kcGNkW0RQX0RPV05T VFJFQU1QT1JUX1BSRVNFTlRdICYKPiAtCQkJRFBfRFdOX1NUUk1fUE9SVF9UWVBFX01BU0s7Cj4g LQkJaWYgKHR5cGUgPT0gRFBfRFdOX1NUUk1fUE9SVF9UWVBFX0FOQUxPRyB8fAo+IC0JCSAgICB0 eXBlID09IERQX0RXTl9TVFJNX1BPUlRfVFlQRV9PVEhFUikKPiAtCQkJcmV0dXJuIGNvbm5lY3Rv cl9zdGF0dXNfdW5rbm93bjsKPiAtCX0KPiAtCj4gLQkvKiBBbnl0aGluZyBlbHNlIGlzIG91dCBv ZiBzcGVjLCB3YXJuIGFuZCBpZ25vcmUgKi8KPiAtCURSTV9ERUJVR19LTVMoIkJyb2tlbiBEUCBi cmFuY2ggZGV2aWNlLCBpZ25vcmluZ1xuIik7Cj4gLQlyZXR1cm4gY29ubmVjdG9yX3N0YXR1c19k aXNjb25uZWN0ZWQ7Cj4gLX0KPiAtCj4gIHN0YXRpYyBlbnVtIGRybV9jb25uZWN0b3Jfc3RhdHVz Cj4gIGVkcF9kZXRlY3Qoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPiAgewo+IC0tIAo+IDEu Ny45LjUKPgo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Cj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKPiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt Z2Z4CgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVy Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdm eCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==