From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57425) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZBHFn-0000B1-Ri for qemu-devel@nongnu.org; Sat, 04 Jul 2015 02:48:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZBHFm-0004Ab-VV for qemu-devel@nongnu.org; Sat, 04 Jul 2015 02:48:47 -0400 From: Markus Armbruster References: <1435713640-12362-1-git-send-email-jsnow@redhat.com> <1435713640-12362-3-git-send-email-jsnow@redhat.com> <871tgp7523.fsf@blackfin.pond.sub.org> <55977058.7070500@redhat.com> Date: Sat, 04 Jul 2015 08:48:38 +0200 In-Reply-To: <55977058.7070500@redhat.com> (John Snow's message of "Sat, 04 Jul 2015 01:34:16 -0400") Message-ID: <87d208wh89.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [RFC 02/10] fdc: add default drive type option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: kwolf@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org John Snow writes: > On 07/03/2015 09:18 AM, Markus Armbruster wrote: [...] >>> diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h >>> index 0cfff1c..0872b41 100644 >>> --- a/include/hw/qdev-properties.h >>> +++ b/include/hw/qdev-properties.h >>> @@ -20,6 +20,7 @@ extern PropertyInfo qdev_prop_ptr; >>> extern PropertyInfo qdev_prop_macaddr; >>> extern PropertyInfo qdev_prop_losttickpolicy; >>> extern PropertyInfo qdev_prop_bios_chs_trans; >>> +extern PropertyInfo qdev_prop_fdc_drive_type; >>> extern PropertyInfo qdev_prop_drive; >>> extern PropertyInfo qdev_prop_netdev; >>> extern PropertyInfo qdev_prop_vlan; >>> diff --git a/qapi/block.json b/qapi/block.json >>> index aad645c..0c747a1 100644 >>> --- a/qapi/block.json >>> +++ b/qapi/block.json >>> @@ -40,6 +40,21 @@ >>> 'data': ['auto', 'none', 'lba', 'large', 'rechs']} >>> >>> ## >>> +# FDRIVE_DRV: >> >> Stick in the usual @, please, just for consistency. >> >> FDRIVE_DRV is an unusual name for a QAPI type. I guess you chose it so >> only the type name changes, but the enumeration constants stay the same. >> You then hide away the type name change with a typedef in fdc.h. >> >> Clever, but I think in the longer run, I'd rather take a more >> conventional type name. >> > > If the rest of the series can be polished, I'll add a more traditional > enum. This was more or less a quick PoC hack to avoid a lot of churn. Makes sense, actually :) [...]