All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: Use HOTPLUG_INT_STATUS_G4X on	VLV/CHV
Date: Tue, 12 May 2015 11:54:23 +0300	[thread overview]
Message-ID: <87d22641mo.fsf@intel.com> (raw)
In-Reply-To: <1431366550-25659-2-git-send-email-ville.syrjala@linux.intel.com>

On Mon, 11 May 2015, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Use HOTPLUG_INT_STATUS_G4X instead of HOTPLUG_INT_STATUS_I915 on VLV/CHV
> so that we don't confuse the AUX status bits with SDVO status bits.
>
> Avoid pointless log spam as below while handling AUX interrupts:
> [drm:intel_hpd_irq_handler] hotplug event received, stat 0x00000040, dig 0x00000000
> [drm:intel_hpd_irq_handler] hotplug event received, stat 0x00000040, dig 0x00000000
> [drm:intel_hpd_irq_handler] hotplug event received, stat 0x00000040, dig 0x00000000
> [drm:intel_hpd_irq_handler] hotplug event received, stat 0x00000040, dig 0x00000000
> [drm:intel_hpd_irq_handler] hotplug event received, stat 0x00000040, dig 0x00000000
> [drm:intel_dp_aux_ch] dp_aux_ch timeout status 0x71450064
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

Shouldn't we also have bugs about missing hotplug on BYT...? Like,
there's a lot of talk about power management on

https://bugs.freedesktop.org/show_bug.cgi?id=89008

but could this make a difference?

BR,
Jani.


> ---
>  drivers/gpu/drm/i915/i915_irq.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index 9c5371b..557af88 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -79,7 +79,7 @@ static const u32 hpd_status_g4x[HPD_NUM_PINS] = {
>  	[HPD_PORT_D] = PORTD_HOTPLUG_INT_STATUS
>  };
>  
> -static const u32 hpd_status_i915[HPD_NUM_PINS] = { /* i915 and valleyview are the same */
> +static const u32 hpd_status_i915[HPD_NUM_PINS] = {
>  	[HPD_CRT] = CRT_HOTPLUG_INT_STATUS,
>  	[HPD_SDVO_B] = SDVOB_HOTPLUG_INT_STATUS_I915,
>  	[HPD_SDVO_C] = SDVOC_HOTPLUG_INT_STATUS_I915,
> @@ -1743,7 +1743,7 @@ static void i9xx_hpd_irq_handler(struct drm_device *dev)
>  		 */
>  		POSTING_READ(PORT_HOTPLUG_STAT);
>  
> -		if (IS_G4X(dev)) {
> +		if (IS_G4X(dev) || IS_VALLEYVIEW(dev)) {
>  			u32 hotplug_trigger = hotplug_status & HOTPLUG_INT_STATUS_G4X;
>  
>  			intel_hpd_irq_handler(dev, hotplug_trigger, 0, hpd_status_g4x);
> -- 
> 2.0.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-05-12  8:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-11 17:49 [PATCH 1/2] drm/i915: Remove excess inline keywords ville.syrjala
2015-05-11 17:49 ` [PATCH 2/2] drm/i915: Use HOTPLUG_INT_STATUS_G4X on VLV/CHV ville.syrjala
2015-05-12  8:54   ` Jani Nikula [this message]
2015-05-12 10:24     ` Daniel Vetter
2015-05-12 10:27     ` Ville Syrjälä
2015-05-12 11:42       ` Daniel Vetter
2015-05-15  4:40   ` shuang.he
2015-05-12  8:52 ` [PATCH 1/2] drm/i915: Remove excess inline keywords Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d22641mo.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.