From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753519AbbDAD1S (ORCPT ); Tue, 31 Mar 2015 23:27:18 -0400 Received: from ozlabs.org ([103.22.144.67]:53983 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753318AbbDAD1Q (ORCPT ); Tue, 31 Mar 2015 23:27:16 -0400 From: Rusty Russell To: Cornelia Huck , "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH] virtio: drop a useless config read In-Reply-To: <20150331150201.34cb8823.cornelia.huck@de.ibm.com> References: <1427802906-7743-1-git-send-email-mst@redhat.com> <20150331150201.34cb8823.cornelia.huck@de.ibm.com> User-Agent: Notmuch/0.17 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Wed, 01 Apr 2015 13:44:49 +1030 Message-ID: <87d23oo7yu.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Cornelia Huck writes: > On Tue, 31 Mar 2015 13:55:42 +0200 > "Michael S. Tsirkin" wrote: > >> commit d71de9ec6ba806104439d3a669befda84757b5af >> "virtio: core support for config generation" >> fixed reading up 64 bit values, adding generation >> checks for such reads. >> >> By mistake, it left an explicit get call in place >> as well. the result is that the value is read twice, >> the first result is discarded. >> >> Not a big deal since this only happens with virtio >> blk and only on boot ATM, so performance isn't >> affected, but let's clean it up. >> >> Signed-off-by: Michael S. Tsirkin >> --- >> include/linux/virtio_config.h | 1 - >> 1 file changed, 1 deletion(-) > > Reviewed-by: Cornelia Huck Applied. Thanks! Rusty.