From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33210)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XwBGz-0001xj-O1
	for qemu-devel@nongnu.org; Wed, 03 Dec 2014 09:51:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XwBGt-0005XT-8O
	for qemu-devel@nongnu.org; Wed, 03 Dec 2014 09:51:21 -0500
Received: from mx1.redhat.com ([209.132.183.28]:60664)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XwBGt-0005XP-1v
	for qemu-devel@nongnu.org; Wed, 03 Dec 2014 09:51:15 -0500
From: Markus Armbruster <armbru@redhat.com>
References: <87vbltvpl0.fsf@blackfin.pond.sub.org>
	<20141203103041.GB4404@noname.str.redhat.com>
	<547F1750.1020600@redhat.com>
Date: Wed, 03 Dec 2014 15:51:08 +0100
In-Reply-To: <547F1750.1020600@redhat.com> (Eric Blake's message of "Wed, 03
	Dec 2014 06:59:44 -0700")
Message-ID: <87d280kcrn.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] Review of monitor commands identifying BDS / BB by
	name
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>, jcody@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com, Stefan Hajnoczi <stefanha@redhat.com>, benoit.canet@nodalink.com

Eric Blake <eblake@redhat.com> writes:

> On 12/03/2014 03:30 AM, Kevin Wolf wrote:
>> [ CCed Beno=C3=AEt and Max, this is blockdev work ]
>> [ CCed Jeff, we're also talking about op blockers ]
>>=20
>> Not stripping quoted text for their convenience.
>
> I still intend to go through this mail in more detail, but off of a
> quick glance, I see you missed a command:
>
> qapi-schema.json:
> * change
>   @device (sometimes) names a backend, with the further restriction that
> no backend can be named 'vnc'

Missed because its handler isn't in block*.  I'll double-check by
examining callers functions monitor commands use to find BBs and BDSes.

> TODO: add new commands that de-multiplex this stupidity.  'change' is
> not extensible, and management should not be using it once the new
> commands are in place

Done: replacement for "change vnc password PASSWORD", namely
set_password and change-vnc-password.  No idea why we added two
commands.

Still missing: replacements for "change vnc DISPLAY" and "change DEVICE
FILENAME [FORMAT]".