From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 2/2] drm/edid: Tighten checksum conditions for CEA blocks Date: Mon, 17 Nov 2014 11:08:48 +0200 Message-ID: <87d28murbz.fsf@intel.com> References: <1416103494-17019-1-git-send-email-stefan.bruens@rwth-aachen.de> <44ca22d7-d28e-4757-b915-0e45fe864900@HUB2.rwth-ad.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id ED9BF6E91A for ; Mon, 17 Nov 2014 01:08:46 -0800 (PST) In-Reply-To: <44ca22d7-d28e-4757-b915-0e45fe864900@HUB2.rwth-ad.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: stefan.bruens@rwth-aachen.de List-Id: dri-devel@lists.freedesktop.org T24gU3VuLCAxNiBOb3YgMjAxNCwgU3RlZmFuIEJyw7xucyA8c3RlZmFuLmJydWVuc0Byd3RoLWFh Y2hlbi5kZT4gd3JvdGU6Cj4gNGE2MzhiNGUzODIzNDIzM2Y1YzdlNjcwNTY2MmZiYzBiNThkODBj MiBkaXNhYmxlZCB0aGUgY2hlY2tzdW1taW5nCgpQbGVhc2UgaW5jbHVkZSB0aGUgc3ViamVjdCBv ZiB0aGUgcmVmZXJlbmNlZCBjb21taXQsIGUuZy4KCjRhNjM4YjRlMzgyMyBkcm0vZWRpZDogQWxs b3cgbm9uLWZhdGFsIGNoZWNrc3VtIGVycm9ycyBpbiBDRUEgYmxvY2tzCgpvcgoKY29tbWl0IDRh NjM4YjRlMzgyMzQyMzNmNWM3ZTY3MDU2NjJmYmMwYjU4ZDgwYzIKQXV0aG9yOiBBZGFtIEphY2tz b24gPGFqYXhAcmVkaGF0LmNvbT4KRGF0ZTogICBUdWUgTWF5IDI1IDE2OjMzOjA5IDIwMTAgLTA0 MDAKCiAgICBkcm0vZWRpZDogQWxsb3cgbm9uLWZhdGFsIGNoZWNrc3VtIGVycm9ycyBpbiBDRUEg YmxvY2tzCgo+IGZvciBDRUEgYmxvY2tzLiBJZiBvbmx5IHRoZSBjaGVja3N1bSBpcyB3cm9uZywg cmVhZGluZyB0d2ljZSBzaG91bGQKPiByZXN1bHQgaW4gaWRlbnRpY2FsIGRhdGEsIHdoZXJlYXMg YSBiYWQgdHJhbnNmZXIgd2lsbCBtb3N0IGxpa2VseQo+IGNvcnJ1cHQgZGlmZmVudCBieXRlcy4K Pgo+IFNpZ25lZC1vZmYtYnk6IFN0ZWZhbiBCcsO8bnMgPHN0ZWZhbi5icnVlbnNAcnd0aC1hYWNo ZW4uZGU+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fZWRpZC5jIHwgMjUgKysrKysrKysr KysrKysrKysrKysrLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMjEgaW5zZXJ0aW9ucygrKSwgNCBk ZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2VkaWQuYyBi L2RyaXZlcnMvZ3B1L2RybS9kcm1fZWRpZC5jCj4gaW5kZXggNTA1OTYwZS4uOWI2YjY1ZSAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2VkaWQuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9kcm1fZWRpZC5jCj4gQEAgLTEyMDAsNiArMTIwMCw3IEBAIGRybV9kb19nZXRfZWRpZChz dHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLCBzdHJ1Y3QgaTJjX2FkYXB0ZXIgKmFkYXB0 ZXIpCj4gIHsKPiAgCWludCBpLCBqID0gMCwgdmFsaWRfZXh0ZW5zaW9ucyA9IDA7Cj4gIAl1OCAq YmxvY2ssICpuZXc7Cj4gKwl1OCAqc2F2ZWRfYmxvY2sgPSBOVUxMOwo+ICAJYm9vbCBwcmludF9i YWRfZWRpZCA9ICFjb25uZWN0b3ItPmJhZF9lZGlkX2NvdW50ZXIgfHwgKGRybV9kZWJ1ZyAmIERS TV9VVF9LTVMpOwo+ICAKPiAgCWlmICgoYmxvY2sgPSBrbWFsbG9jKEVESURfTEVOR1RILCBHRlBf S0VSTkVMKSkgPT0gTlVMTCkKPiBAQCAtMTIzNCwxNSArMTIzNSwyOSBAQCBkcm1fZG9fZ2V0X2Vk aWQoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3Rvciwgc3RydWN0IGkyY19hZGFwdGVyICph ZGFwdGVyKQo+ICAJYmxvY2sgPSBuZXc7Cj4gIAo+ICAJZm9yIChqID0gMTsgaiA8PSBibG9ja1sw eDdlXTsgaisrKSB7Cj4gKwkJdTggKmV4dF9ibG9jayA9IGJsb2NrICsgKHZhbGlkX2V4dGVuc2lv bnMgKyAxKSAqIEVESURfTEVOR1RIOwoKVGhpcyBiaXQgY291bGQgYmUgYSBub24tZnVuY3Rpb25h bCBwcmVwIHBhdGNoLgoKPiArCQl1OCBjc3VtLCBsYXN0X2NzdW0gPSAwOwo+ICAJCWZvciAoaSA9 IDA7IGkgPCA0OyBpKyspIHsKPiAtCQkJaWYgKGRybV9kb19wcm9iZV9kZGNfZWRpZChhZGFwdGVy LAo+IC0JCQkJICBibG9jayArICh2YWxpZF9leHRlbnNpb25zICsgMSkgKiBFRElEX0xFTkdUSCwK PiAtCQkJCSAgaiwgRURJRF9MRU5HVEgpKQo+ICsJCQlpZiAoZHJtX2RvX3Byb2JlX2RkY19lZGlk KGFkYXB0ZXIsIGV4dF9ibG9jaywgaiwgRURJRF9MRU5HVEgpKQo+ICAJCQkJZ290byBvdXQ7Cj4g LQkJCWlmIChkcm1fZWRpZF9ibG9ja192YWxpZChibG9jayArICh2YWxpZF9leHRlbnNpb25zICsg MSkgKiBFRElEX0xFTkdUSCwgaiwgcHJpbnRfYmFkX2VkaWQpKSB7CgpOb3cgeW91IHNraXAgZHJt X2VkaWRfYmxvY2tfdmFsaWQgZm9yIGFsbCBibG9ja3M/Cgo+ICsJCQlpZiAoKGNzdW0gPSBkcm1f ZWRpZF9ibG9ja19jaGVja3N1bShleHRfYmxvY2spKSA9PSAwKSB7CgpQbGVhc2UgZG9uJ3QgYXNz aWduIHdpdGhpbiB0aGUgaWYgY29uZGl0aW9uLgoKPiAgCQkJCXZhbGlkX2V4dGVuc2lvbnMrKzsK PiAgCQkJCWJyZWFrOwo+ICsJCQl9IGVsc2UgaWYgKChleHRfYmxvY2tbMF0gPT0gQ0VBX0VYVCkg JiYgKGNzdW0gPT0gbGFzdF9jc3VtKSkgewoKVG9vIG1hbnkgYnJhY2VzLgoKUGVyaGFwcyBpdCB3 b3VsZCBiZSBzdWZmaWNpZW50IHRvIGp1c3QgY2hlY2sgY2hlY2tzdW1zIGluc3RlYWQgb2YKY29t cGFyaW5nIHRoZSBkYXRhPyAqc2hydWcqLgoKPiArCQkJLyoKPiArCQkJICogU29tZSBzd2l0Y2hl cyBtYW5nbGUgQ0VBIGNvbnRlbnRzIHdpdGhvdXQgZml4aW5nIHRoZSBjaGVja3N1bS4KPiArCQkJ ICogQWNjZXB0IENFQSBibG9ja3Mgd2hlbiB0d28gcmVhZHMgcmV0dXJuIGlkZW50aWNhbCBkYXRh Lgo+ICsJCQkgKi8KClNvIHlvdSBlbmQgdXAgaGVyZSBvbiB0aGUgMm5kIHRpbWUgeW91IGdldCBp ZGVudGljYWwgY2hlY2tzdW1zLCBidXQgeW91CmRvbid0IGhhdmUgdGhlIHNhdmVkX2Jsb2NrIGZv ciB0aGUgMXN0IGF0dGVtcHQuIFRoZXJlZm9yZSB5b3UgZW5kIHVwCnNhdmluZyB0aGUgMm5kIGF0 dGVtcHQgYW5kIGdvIGZvciBhIDNyZCBhdHRlbXB0IHRvIGVuZCB1cCBoZXJlLgoKPiArCQkJCWlm ICghc2F2ZWRfYmxvY2spCj4gKwkJCQkJc2F2ZWRfYmxvY2sgPSBrbWFsbG9jKEVESURfTEVOR1RI LCBHRlBfS0VSTkVMKTsKPiArCQkJCWlmIChzYXZlZF9ibG9jayAmJiAhbWVtY21wKGV4dF9ibG9j aywgc2F2ZWRfYmxvY2ssIEVESURfTEVOR1RIKSkgewoKT24gdGhlIDJuZCBhdHRlbXB0IHlvdSBj b21wYXJlIGV4dF9ibG9jayB0byB3aGF0ZXZlciBrbWFsbG9jIHJldHVybmVkCnlvdS4KCj4gKwkJ CQkJdmFsaWRfZXh0ZW5zaW9ucysrOwo+ICsJCQkJCWJyZWFrOwo+ICsJCQkJfQo+ICsJCQkJaWYg KHNhdmVkX2Jsb2NrKQo+ICsJCQkJCW1lbWNweShzYXZlZF9ibG9jaywgZXh0X2Jsb2NrLCBFRElE X0xFTkdUSCk7CgpZb3Ugc2hvdWxkIHVzZSBrbWVtZHVwLCBhbmQgcmVhcnJhbmdlIHRoZSBjb2Rl IHRvIGRvIHdoYXQgaXQgc2F5cyBvbiB0aGUKY29tbWl0IG1lc3NhZ2UuCgpCUiwKSmFuaS4KCj4g IAkJCX0KPiArCQkJbGFzdF9jc3VtID0gY3N1bTsKPiAgCQl9Cj4gIAo+ICAJCWlmIChpID09IDQg JiYgcHJpbnRfYmFkX2VkaWQpIHsKPiBAQCAtMTI2Myw2ICsxMjc4LDcgQEAgZHJtX2RvX2dldF9l ZGlkKHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsIHN0cnVjdCBpMmNfYWRhcHRlciAq YWRhcHRlcikKPiAgCQlibG9jayA9IG5ldzsKPiAgCX0KPiAgCj4gKwlrZnJlZShzYXZlZF9ibG9j ayk7Cj4gIAlyZXR1cm4gYmxvY2s7Cj4gIAo+ICBjYXJwOgo+IEBAIC0xMjczLDYgKzEyODksNyBA QCBjYXJwOgo+ICAJY29ubmVjdG9yLT5iYWRfZWRpZF9jb3VudGVyKys7Cj4gIAo+ICBvdXQ6Cj4g KwlrZnJlZShzYXZlZF9ibG9jayk7Cj4gIAlrZnJlZShibG9jayk7Cj4gIAlyZXR1cm4gTlVMTDsK PiAgfQo+IC0tIAo+IDEuOC40LjUKPgo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vZHJpLWRldmVsCgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIFRl Y2hub2xvZ3kgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl dmVsCg==