From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58780)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XYw9r-0005XJ-Ok
	for qemu-devel@nongnu.org; Tue, 30 Sep 2014 08:04:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XYw9l-00068y-J6
	for qemu-devel@nongnu.org; Tue, 30 Sep 2014 08:03:55 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59195)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XYw9l-00067m-CR
	for qemu-devel@nongnu.org; Tue, 30 Sep 2014 08:03:49 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1410891148-28849-1-git-send-email-armbru@redhat.com>
	<1410891148-28849-4-git-send-email-armbru@redhat.com>
	<20140930104036.GD3943@noname.str.redhat.com>
	<87egut5qch.fsf@blackfin.pond.sub.org>
	<20140930111033.GG3943@noname.str.redhat.com>
Date: Tue, 30 Sep 2014 14:03:37 +0200
In-Reply-To: <20140930111033.GG3943@noname.str.redhat.com> (Kevin Wolf's
	message of "Tue, 30 Sep 2014 13:10:33 +0200")
Message-ID: <87d2ad48o6.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v3 03/23] block: Connect BlockBackend to
	BlockDriverState
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: stefanha@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, benoit.canet@nodalink.com, mreitz@redhat.com

Kevin Wolf <kwolf@redhat.com> writes:

> Am 30.09.2014 um 12:56 hat Markus Armbruster geschrieben:
>> Kevin Wolf <kwolf@redhat.com> writes:
[...]
>> > Taking back my R-b: You tricked us, this assertion doesn't hold true.
>> > Easy to reproduce by taking a live snapshot. qemu-iotests case 052
>> > catches it. Didn't you run it?
>> 
>> I run "make check-qtest check-block" on every commit before I submit.
>> No idea what went wrong with this one.
>
> When run for raw, it's only 052 that catches it. For qcow2, I got some
> more failures: 039 040 041 051 052 085
>
> I see the problem: Only 039 and 052 are marked as 'quick', i.e. the rest
> is already excluded from 'make check-block'. 039 and 052 don't work with
> cache=none and 'make check-block' uses -nocache, so those are skipped as
> well.

Yes, that's why I missed it.

>       I'll send a patch to remove the -nocache option and let it run
> with the default options.

Appreciated!