From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41412)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@pond.sub.org>) id 1X5Z8O-0007xV-LH
	for qemu-devel@nongnu.org; Fri, 11 Jul 2014 07:37:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@pond.sub.org>) id 1X5Z8J-0001mz-7q
	for qemu-devel@nongnu.org; Fri, 11 Jul 2014 07:37:00 -0400
Received: from oxygen.pond.sub.org ([2a01:4f8:201:233:1::3]:34165)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@pond.sub.org>) id 1X5Z8J-0001mc-17
	for qemu-devel@nongnu.org; Fri, 11 Jul 2014 07:36:55 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1405071380-13652-1-git-send-email-kraxel@redhat.com>
	<1405071380-13652-2-git-send-email-kraxel@redhat.com>
	<87k37k9mab.fsf@blackfin.pond.sub.org>
	<CAFEAcA_4WGMOjRWydDkS03GHNUjhPeS_HZKm_W7Zc0pbRJjcUQ@mail.gmail.com>
Date: Fri, 11 Jul 2014 13:36:52 +0200
In-Reply-To: <CAFEAcA_4WGMOjRWydDkS03GHNUjhPeS_HZKm_W7Zc0pbRJjcUQ@mail.gmail.com>
	(Peter Maydell's message of "Fri, 11 Jul 2014 12:20:09 +0100")
Message-ID: <87d2dc6sa3.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PULL 1/1] spice: auth fixes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Gerd Hoffmann <kraxel@redhat.com>, Anthony Liguori <aliguori@amazon.com>, QEMU Developers <qemu-devel@nongnu.org>

Peter Maydell <peter.maydell@linaro.org> writes:

> On 11 July 2014 12:18, Markus Armbruster <armbru@redhat.com> wrote:
>> Gerd Hoffmann <kraxel@redhat.com> writes:
>>
>>> Set auth to sasl when sasl is enabled, this makes "info spice" correctly
>>> display sasl auth.
>>
>> Fixes SPICE_CHANNEL_EVENT_CONNECTED similarly, doesn't it?
>>
>> If yes, I'd recommend to note this in the commit message.
>>
>>>                     Also throw an error in case someone tries to set
>>> a spice password via monitor without auth mode being "spice".
>>>
>>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>>
>> Since the patch looks fine to me:
>>
>> Reviewed-by: Markus Armbruster <armbru@redhat.com>
>
> Bit late now, given this is the pullreq; original patch was on
> list for review 2 July.

I spotted the PULL in the subject right after I sent %-}