Re: [Qemu-devel] [PATCH 1/3 v3] ppc: spapr-rtas - implement os-term rtas call

[Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>]

Alexey Kardashevskiy <aik@au1.ibm.com> writes:

> On 06/27/2014 04:47 PM, Nikunj A Dadhania wrote:
>> PAPR compliant guest calls this in absence of kdump. This finally
>> reaches the guest and can be handled according to the policies set by
>> higher level tools(like taking dump) for further analysis by tools like
>> crash.
>> 
>> Linux kernel calls this only when the extended version of os,term is
>> implemented to make sure that a return to the linux kernel is gauranteed.
>> 
>> CC: Benjamin Herrenschmidt <benh@au1.ibm.com>
>> CC: Anton Blanchard <anton@samba.org>
>> CC: Alexander Graf <agraf@suse.de>
>> Signed-off-by: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
>> 
>>  static struct rtas_call {
>>      const char *name;
>>      spapr_rtas_fn fn;
>> @@ -404,6 +441,10 @@ static void core_rtas_register_types(void)
>>      spapr_rtas_register(RTAS_IBM_SET_SYSTEM_PARAMETER,
>>                          "ibm,set-system-parameter",
>>                          rtas_ibm_set_system_parameter);
>> +    spapr_rtas_register("ibm,os-term",
>> +                        rtas_ibm_os_term);
>
>
> This just won't compile, spapr_rtas_register() takes 3 parameters now.

duh, i missed that update :(

Resending

> Tokens for "ibm,os-term" and "ibm,extended-os-term" are already defined,
> just use them.
>
>
>
>> +    spapr_rtas_register("ibm,extended-os-term",
>> +                        rtas_ibm_ext_os_term);
>>  }
>>  
>>  type_init(core_rtas_register_types)
>> 
>
>
> ps. please (please) do not use my ibm's email in public :)

Sure.

Regards
Nikunj