From: Sergei Organov <osv@javad.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: Surprising 'git-describe --all --match' behavior.
Date: Thu, 19 Jun 2014 22:58:00 +0400 [thread overview]
Message-ID: <87d2e4d8w7.fsf@osv.gnss.ru> (raw)
In-Reply-To: <xmqqr42khl3l.fsf@gitster.dls.corp.google.com> (Junio C. Hamano's message of "Thu, 19 Jun 2014 10:20:46 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> Sergei Organov <osv@javad.com> writes:
>
>> Just playing with it, got some surprises:
>>
>> $ git --version
>> git version 1.9.3
>>
>> $ git describe --all
>> heads/v3.5
>> $ git describe --all --match 'v*'
>> tags/v3.5.6b2-4-gab4bf78
>> $ git describe --all --match 'heads/v*'
>> fatal: No names found, cannot describe anything.
>
> I think
>
> $ git describe --help
>
> ...
> --match <pattern>
> Only consider tags matching the given glob(7) pattern,
> excluding the "refs/tags/" prefix. This can be used to
> avoid leaking private tags from the repository.
> ...
>
> is poorly phrased, especially its "excluding" part. What it wants
> to say is "You give <pattern> but without refs/tags/, because the
> program helpfully always prepend refs/tags/ to your pattern and
> limit the output to those that match". Hence you gave 'v*' as
> <pattern> and limited the output to those that match 'refs/tags/v*'
> (or you gave 'heads/v*' and limited to 'refs/tags/heads/v*').
OK, thanks, at least I now see how it works. So no <pattern> can ever
match any reference but tag, even when --all switch is given? If so,
appearance of --match effectively turns --all into --tags, that is still
rather confusing, isn't it?
Will something break if it won't helpfully prepend refs/tags/ once
--all is given?
--
Sergei.
next prev parent reply other threads:[~2014-06-19 18:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 13:31 Surprising 'git-describe --all --match' behavior Sergei Organov
2014-06-19 17:20 ` Junio C Hamano
2014-06-19 18:58 ` Sergei Organov [this message]
2014-06-19 19:10 ` Junio C Hamano
2014-06-19 20:12 ` Sergei Organov
2014-06-19 21:50 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2e4d8w7.fsf@osv.gnss.ru \
--to=osv@javad.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.