From: Jani Nikula <jani.nikula@linux.intel.com>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH] drm/i915: move dev_priv->suspend around
Date: Wed, 12 Mar 2014 11:01:35 +0200 [thread overview]
Message-ID: <87d2hr23kg.fsf@intel.com> (raw)
In-Reply-To: <1394442185-30509-1-git-send-email-daniel.vetter@ffwll.ch>
On Mon, 10 Mar 2014, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> When adding new gunk, _always_ think of a good place. Start/end
> usually just means that this didn't happen, and on top of that results
> in needless conflicts with other patches doing the same.
I'm a fan of unnamed structs within structs to group stuff. The .wm one
in dev priv is a great example.
BR,
Jani.
>
> Introduced in
>
> commit 62d5d69b49b6fea9905e36e67cc6c4fc5a17d75f
> Author: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Date: Tue Feb 25 17:11:28 2014 +0200
>
> drm/i915: Add suspend count to error state
>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/i915/i915_drv.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index bfb537942dbe..ba4f2b1d0c7f 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -1613,6 +1613,7 @@ typedef struct drm_i915_private {
>
> u32 fdi_rx_config;
>
> + u32 suspend_count;
> struct i915_suspend_saved_registers regfile;
>
> struct {
> @@ -1641,8 +1642,6 @@ typedef struct drm_i915_private {
> struct i915_dri1_state dri1;
> /* Old ums support infrastructure, same warning applies. */
> struct i915_ums_state ums;
> -
> - u32 suspend_count;
> } drm_i915_private_t;
>
> static inline struct drm_i915_private *to_i915(const struct drm_device *dev)
> --
> 1.8.5.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-03-12 9:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 9:03 [PATCH] drm/i915: move dev_priv->suspend around Daniel Vetter
2014-03-12 9:01 ` Jani Nikula [this message]
2014-03-12 15:12 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2hr23kg.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.