From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: move dev_priv->suspend around Date: Wed, 12 Mar 2014 11:01:35 +0200 Message-ID: <87d2hr23kg.fsf@intel.com> References: <1394442185-30509-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 29EA9FAA9A for ; Wed, 12 Mar 2014 02:01:41 -0700 (PDT) In-Reply-To: <1394442185-30509-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Intel Graphics Development Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Mon, 10 Mar 2014, Daniel Vetter wrote: > When adding new gunk, _always_ think of a good place. Start/end > usually just means that this didn't happen, and on top of that results > in needless conflicts with other patches doing the same. I'm a fan of unnamed structs within structs to group stuff. The .wm one in dev priv is a great example. BR, Jani. > > Introduced in > > commit 62d5d69b49b6fea9905e36e67cc6c4fc5a17d75f > Author: Mika Kuoppala > Date: Tue Feb 25 17:11:28 2014 +0200 > > drm/i915: Add suspend count to error state > > Cc: Mika Kuoppala > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/i915/i915_drv.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index bfb537942dbe..ba4f2b1d0c7f 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -1613,6 +1613,7 @@ typedef struct drm_i915_private { > > u32 fdi_rx_config; > > + u32 suspend_count; > struct i915_suspend_saved_registers regfile; > > struct { > @@ -1641,8 +1642,6 @@ typedef struct drm_i915_private { > struct i915_dri1_state dri1; > /* Old ums support infrastructure, same warning applies. */ > struct i915_ums_state ums; > - > - u32 suspend_count; > } drm_i915_private_t; > > static inline struct drm_i915_private *to_i915(const struct drm_device *dev) > -- > 1.8.5.2 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center