From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: [PATCH] drivers: virtio: Mark function virtballoon_migratepage() as static in virtio_balloon.c Date: Tue, 17 Dec 2013 15:09:22 +1030 Message-ID: <87d2kwm6px.fsf@rustcorp.com.au> References: <20131216112408.GA4896@rashika> <20131216142338.GA24172@leaf> <20131216142911.GA21241@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20131216142911.GA21241@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: "Michael S. Tsirkin" , Josh Triplett Cc: Rashika Kheria , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org List-Id: virtualization@lists.linuxfoundation.org Ik1pY2hhZWwgUy4gVHNpcmtpbiIgPG1zdEByZWRoYXQuY29tPiB3cml0ZXM6Cj4gT24gTW9uLCBE ZWMgMTYsIDIwMTMgYXQgMDY6MjM6MzhBTSAtMDgwMCwgSm9zaCBUcmlwbGV0dCB3cm90ZToKPj4g T24gTW9uLCBEZWMgMTYsIDIwMTMgYXQgMDQ6NTQ6MDhQTSArMDUzMCwgUmFzaGlrYSBLaGVyaWEg d3JvdGU6Cj4+ID4gTWFyayB0aGUgZnVuY3Rpb24gdmlydGJhbGxvb25fbWlncmF0ZXBhZ2UoKSBh cyBzdGF0aWMgaW4KPj4gPiB2aXJ0aW9fYmFsbG9vbi5jIGJlY2F1c2UgaXQgaXMgbm90IHVzZWQg b3V0c2lkZSB0aGlzIGZpbGUuCj4+ID4gCj4+ID4gVGhpcyBlbGltaW5hdGVzIHRoZSBmb2xsb3dp bmcgd2FybmluZyBpbiB2aXJ0aW9fYmFsbG9vbi5jOgo+PiA+IGRyaXZlcnMvdmlydGlvL3ZpcnRp b19iYWxsb29uLmM6MzcyOjU6IHdhcm5pbmc6IG5vIHByZXZpb3VzIHByb3RvdHlwZSBmb3Ig4oCY dmlydGJhbGxvb25fbWlncmF0ZXBhZ2XigJkgWy1XbWlzc2luZy1wcm90b3R5cGVzXQo+PiA+IAo+ PiA+IFNpZ25lZC1vZmYtYnk6IFJhc2hpa2EgS2hlcmlhIDxyYXNoaWthLmtoZXJpYUBnbWFpbC5j b20+Cj4+IAo+PiBSZXZpZXdlZC1ieTogSm9zaCBUcmlwbGV0dCA8am9zaEBqb3NodHJpcGxldHQu b3JnPgo+Cj4gQWNrZWQtYnk6IE1pY2hhZWwgUy4gVHNpcmtpbiA8bXN0QHJlZGhhdC5jb20+CgpU aGFua3MsIGFwcGxpZWQuCgpDaGVlcnMsClJ1c3R5LgoKPgo+PiA+ICBkcml2ZXJzL3ZpcnRpby92 aXJ0aW9fYmFsbG9vbi5jIHwgICAgMiArLQo+PiA+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRp b24oKyksIDEgZGVsZXRpb24oLSkKPj4gPiAKPj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy92aXJ0 aW8vdmlydGlvX2JhbGxvb24uYyBiL2RyaXZlcnMvdmlydGlvL3ZpcnRpb19iYWxsb29uLmMKPj4g PiBpbmRleCBjNDQ0NjU0Li44YzU5NDNkIDEwMDY0NAo+PiA+IC0tLSBhL2RyaXZlcnMvdmlydGlv L3ZpcnRpb19iYWxsb29uLmMKPj4gPiArKysgYi9kcml2ZXJzL3ZpcnRpby92aXJ0aW9fYmFsbG9v bi5jCj4+ID4gQEAgLTM2OSw3ICszNjksNyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGFkZHJlc3Nf c3BhY2Vfb3BlcmF0aW9ucyB2aXJ0aW9fYmFsbG9vbl9hb3BzOwo+PiA+ICAgKiBUaGlzIGZ1bmN0 aW9uIHByZWZvcm1zIHRoZSBiYWxsb29uIHBhZ2UgbWlncmF0aW9uIHRhc2suCj4+ID4gICAqIENh bGxlZCB0aHJvdWdoIGJhbGxvb25fbWFwcGluZy0+YV9vcHMtPm1pZ3JhdGVwYWdlCj4+ID4gICAq Lwo+PiA+IC1pbnQgdmlydGJhbGxvb25fbWlncmF0ZXBhZ2Uoc3RydWN0IGFkZHJlc3Nfc3BhY2Ug Km1hcHBpbmcsCj4+ID4gK3N0YXRpYyBpbnQgdmlydGJhbGxvb25fbWlncmF0ZXBhZ2Uoc3RydWN0 IGFkZHJlc3Nfc3BhY2UgKm1hcHBpbmcsCj4+ID4gIAkJc3RydWN0IHBhZ2UgKm5ld3BhZ2UsIHN0 cnVjdCBwYWdlICpwYWdlLCBlbnVtIG1pZ3JhdGVfbW9kZSBtb2RlKQo+PiA+ICB7Cj4+ID4gIAlz dHJ1Y3QgYmFsbG9vbl9kZXZfaW5mbyAqdmJfZGV2X2luZm8gPSBiYWxsb29uX3BhZ2VfZGV2aWNl KHBhZ2UpOwo+PiA+IC0tIAo+PiA+IDEuNy45LjUKPj4gPiAKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KVmlydHVhbGl6YXRpb24gbWFpbGluZyBsaXN0ClZp cnR1YWxpemF0aW9uQGxpc3RzLmxpbnV4LWZvdW5kYXRpb24ub3JnCmh0dHBzOi8vbGlzdHMubGlu dXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZvL3ZpcnR1YWxpemF0aW9u From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752273Ab3LQEye (ORCPT ); Mon, 16 Dec 2013 23:54:34 -0500 Received: from ozlabs.org ([203.10.76.45]:46162 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751910Ab3LQEyd convert rfc822-to-8bit (ORCPT ); Mon, 16 Dec 2013 23:54:33 -0500 From: Rusty Russell To: "Michael S. Tsirkin" , Josh Triplett Cc: Rashika Kheria , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH] drivers: virtio: Mark function virtballoon_migratepage() as static in virtio_balloon.c In-Reply-To: <20131216142911.GA21241@redhat.com> References: <20131216112408.GA4896@rashika> <20131216142338.GA24172@leaf> <20131216142911.GA21241@redhat.com> User-Agent: Notmuch/0.15.2 (http://notmuchmail.org) Emacs/23.4.1 (x86_64-pc-linux-gnu) Date: Tue, 17 Dec 2013 15:09:22 +1030 Message-ID: <87d2kwm6px.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "Michael S. Tsirkin" writes: > On Mon, Dec 16, 2013 at 06:23:38AM -0800, Josh Triplett wrote: >> On Mon, Dec 16, 2013 at 04:54:08PM +0530, Rashika Kheria wrote: >> > Mark the function virtballoon_migratepage() as static in >> > virtio_balloon.c because it is not used outside this file. >> > >> > This eliminates the following warning in virtio_balloon.c: >> > drivers/virtio/virtio_balloon.c:372:5: warning: no previous prototype for ‘virtballoon_migratepage’ [-Wmissing-prototypes] >> > >> > Signed-off-by: Rashika Kheria >> >> Reviewed-by: Josh Triplett > > Acked-by: Michael S. Tsirkin Thanks, applied. Cheers, Rusty. > >> > drivers/virtio/virtio_balloon.c | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c >> > index c444654..8c5943d 100644 >> > --- a/drivers/virtio/virtio_balloon.c >> > +++ b/drivers/virtio/virtio_balloon.c >> > @@ -369,7 +369,7 @@ static const struct address_space_operations virtio_balloon_aops; >> > * This function preforms the balloon page migration task. >> > * Called through balloon_mapping->a_ops->migratepage >> > */ >> > -int virtballoon_migratepage(struct address_space *mapping, >> > +static int virtballoon_migratepage(struct address_space *mapping, >> > struct page *newpage, struct page *page, enum migrate_mode mode) >> > { >> > struct balloon_dev_info *vb_dev_info = balloon_page_device(page); >> > -- >> > 1.7.9.5 >> >