From: Thomas Rast <tr@thomasrast.ch>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: What's cooking in git.git (Nov 2013, #05; Thu, 21)
Date: Fri, 22 Nov 2013 17:52:37 +0100 [thread overview]
Message-ID: <87d2lsjs4q.fsf@linux-k42r.v.cablecom.net> (raw)
In-Reply-To: <20131122102345.GC12042@sigill.intra.peff.net> (Jeff King's message of "Fri, 22 Nov 2013 05:23:45 -0500")
Jeff King <peff@peff.net> writes:
>> * jk/pack-bitmap (2013-11-18) 22 commits
[...]
>> Borrows the bitmap index into packfiles from JGit to speed up
>> enumeration of objects involved in a commit range without having to
>> fully traverse the history.
>
> Looks like you picked up my latest re-roll with Ramsay's fix on top.
> There wasn't a lot of review on this past round (I'm not surprised; it's
> a dauntingly large chunk to review). I outlined a few possible open
> issues in the cover letter, but I'd be happy to build those on top,
> which I think will make review of them a lot easier.
>
> Do we want to try this in 'next' post-1.8.5, or should I try to prod an
> area expert like Shawn into doing another round of review?
Hmm, maybe I missed something, but AFAICS you (or Vicent) never acted on
or responded to my June reviews in this thread:
http://thread.gmane.org/gmane.comp.version-control.git/228918
and again mentioned here, though I didn't point out all of them:
http://thread.gmane.org/gmane.comp.version-control.git/236587/focus=236740
Granted, the way I verified this was checking whether you renamed
rlw_xor_run_bit() to something more fitting, so perhaps you just forgot
that one thing but did all the rest.
--
Thomas Rast
tr@thomasrast.ch
next prev parent reply other threads:[~2013-11-22 16:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-22 0:19 What's cooking in git.git (Nov 2013, #05; Thu, 21) Junio C Hamano
2013-11-22 10:23 ` Jeff King
2013-11-22 16:52 ` Thomas Rast [this message]
2013-11-22 17:26 ` Jeff King
2013-11-22 17:58 ` Thomas Rast
2013-11-22 22:36 ` Jeff King
2013-11-22 23:04 ` Thomas Rast
2013-11-22 19:40 ` Vicent Marti
2013-11-22 20:16 ` Thomas Rast
2013-11-22 19:36 ` Junio C Hamano
2013-11-22 19:47 ` Vicent Martí
2013-11-22 20:05 ` Junio C Hamano
2013-11-22 22:32 ` Jeff King
2013-11-23 11:25 ` Antoine Pelisse
2013-11-25 16:17 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2lsjs4q.fsf@linux-k42r.v.cablecom.net \
--to=tr@thomasrast.ch \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.