[ath9k-devel] [PATCH] ath10k: kill static int max_delay

[Kalle Valo <kvalo@qca.qualcomm.com>]

Janusz Dziedzic <janusz.dziedzic@tieto.com> writes:

> Kill static variable max_delay.
> Move this to struct ath10k_pci.
>
> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com>
> ---
>  drivers/net/wireless/ath/ath10k/pci.c |    5 ++---
>  drivers/net/wireless/ath/ath10k/pci.h |    2 ++
>  2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c
> index 0d1523b..9ee678a 100644
> --- a/drivers/net/wireless/ath/ath10k/pci.c
> +++ b/drivers/net/wireless/ath/ath10k/pci.c
> @@ -445,7 +445,6 @@ void ath10k_do_pci_wake(struct ath10k *ar)
>  {
>  	struct ath10k_pci *ar_pci = ath10k_pci_priv(ar);
>  	void __iomem *pci_addr = ar_pci->mem;
> -	static int max_delay;
>  	int tot_delay = 0;
>  	int curr_delay = 5;
>  
> @@ -475,8 +474,8 @@ void ath10k_do_pci_wake(struct ath10k *ar)
>  			curr_delay += 5;
>  	}
>  
> -	if (tot_delay > max_delay)
> -		max_delay = tot_delay;
> +	if (tot_delay > ar_pci->max_delay)
> +		ar_pci->max_delay = tot_delay;
>  }

But do we use this max_delay value for anything sensible? The way I see
it we only store values but don't do anything with it. Unless I'm
missing something, of course.

-- 
Kalle Valo