From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Date: Tue, 23 Apr 2013 10:29:49 +0300 Subject: [ath9k-devel] [PATCH 1/3] ath10k: kill A_PCIE_LOCAL_REG_READ In-Reply-To: <1366637004-9424-2-git-send-email-bartosz.markowski@tieto.com> (Bartosz Markowski's message of "Mon, 22 Apr 2013 15:23:22 +0200") References: <1366637004-9424-1-git-send-email-bartosz.markowski@tieto.com> <1366637004-9424-2-git-send-email-bartosz.markowski@tieto.com> Message-ID: <87d2tlg0wi.fsf@kamboji.qca.qualcomm.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org Bartosz Markowski writes: > Signed-off-by: Bartosz Markowski [...] > -#define A_PCIE_LOCAL_REG_READ(mem, addr) \ > - ioread32((mem) + PCIE_LOCAL_BASE_ADDRESS_T(ar) + (u32)(addr)) I think it would be better to convert this to a function and call it ath10k_pci_reg_read32() or something like that. And the same for the write function. -- Kalle Valo