Re: [Qemu-devel] [PATCH v6 0/7] virtio-serial refactoring.

[Anthony Liguori <aliguori@us.ibm.com>]

Peter Maydell <peter.maydell@linaro.org> writes:

> On 9 April 2013 13:53,  <fred.konrad@greensocs.com> wrote:
>> From: KONRAD Frederic <fred.konrad@greensocs.com>
>>
>> This is the next part of virtio-refactoring.
>>
>> Basically it creates virtio-serial device which extends virtio-device.
>> Then a virtio-serial can be connected on a virtio-bus.
>> virtio-serial-pci, virtio-serial-s390 and virtio-serial-ccw are created too,
>> they extend respectively virtio-pci, virtio-s390-device, virtio-ccw-device and
>> have a virtio-serial.
>>
>> Tested-by: Cornelia Huck <cornelia.huck@de.ibm.com>
>> Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
>> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>
> Note to Anthony -- the way Fred has put the R-b: tags in
> his cover letter here seems to confuse your 'patches'
> script. 'patches apply' applies the patches and adds these
> tags to every patch in the series, but
>   patches list id:1365512016-21944-1-git-send-email-fred.konrad@greensocs.com
> status:reviewed
>
> produces no output.

I think you need to update your patches install because it works for me:

$ patches list id:1365512016-21944-1-git-send-email-fred.konrad@greensocs.com status:reviewed
Message-id: 1365512016-21944-1-git-send-email-fred.konrad@greensocs.com
From:  <fred.konrad@greensocs.com>
Date: 2013-04-09
Tags: v6
   [0/7] virtio-serial refactoring.
   [1/7] virtio-serial: add the virtio-serial device.
   [2/7] virtio-serial-pci: switch to the new API.
   [3/7] virtio-serial-s390: switch to the new API.
   [4/7] virtio-serial-ccw: switch to the new API.
   [5/7] virtio-serial: cleanup: init and exit functions.
   [6/7] virtio-serial: cleanup: use QOM casts.
   [7/7] virtio-serial: cleanup: remove qdev field.

Regards,

Anthony Liguori

>
> I flag this up because this patch series will probably not appear
> on your radar otherwise.
>
> Fred: the usual convention is to put reviewed-by
> tags on the patches themselves when resending, even
> if the reviewers were lazy and replied to the coverletter.
>
> thanks
> -- PMM