All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Chris Samuel <chris@csamuel.org>,
	linux-kernel@vger.kernel.org, dhowells@redhat.com,
	Josh Boyer <jwboyer@gmail.com>
Subject: Re: [PATCH] MODSIGN: Warn when module signature checking fails
Date: Mon, 21 Jan 2013 12:11:03 +1030	[thread overview]
Message-ID: <87d2wzwbww.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20130121113430.460efbd10537801cab90af5b@canb.auug.org.au>

Stephen Rothwell <sfr@canb.auug.org.au> writes:

> Hi Rusty,
>
> On Mon, 21 Jan 2013 10:06:11 +1030 Rusty Russell <rusty@rustcorp.com.au> wrote:
>>
>>  #ifdef CONFIG_MODULE_SIG
>>  	mod->sig_ok = info->sig_ok;
>> -	if (!mod->sig_ok)
>> +	if (!mod->sig_ok) {
>> +		printk_once(KERN_NOTICE
>> +			    "%s: module verification failed: signature and/or"
>> +			    " required key missing - tainting kernel\n");
>
> Did you forget to add "mod->name"?

Indeed (turns back on CONFIG_MODULE_SIG).

Thanks,
Rusty.


  reply	other threads:[~2013-01-21  1:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-16 10:14 [PATCH] MODSIGN: Warn when module signature checking fails Chris Samuel
2013-01-20 23:36 ` Rusty Russell
2013-01-21  0:34   ` Stephen Rothwell
2013-01-21  1:41     ` Rusty Russell [this message]
2013-01-21 22:54   ` Chris Samuel
2013-01-22  4:24     ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d2wzwbww.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=chris@csamuel.org \
    --cc=dhowells@redhat.com \
    --cc=jwboyer@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.