Re: [Qemu-devel] [PATCH] build: change dist target to use xz

[Anthony Liguori <anthony@codemonkey.ws>]

Brad Smith <brad@comstyle.com> writes:

> If a compression format other than gzip is used we might
> as well move to xz instead of bzip2.

xz support was introduced in tar only in 2009.  We only expose one
source tarball and I don't think relying on something so new is a good
idea.

Regards,

Anthoyn Liguori

>
> 11.0M qemu-1.1.1-1.tar.gz
> 9.2M  qemu-1.1.1-1.tar.bz2
> 7.3M  qemu-1.1.1-1.tar.xz
>
> ---
>  Makefile             |    6 +++---
>  scripts/make-release |    2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 621cb86..9fbaa0e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -234,10 +234,10 @@ clean:
>  
>  VERSION ?= $(shell cat VERSION)
>  
> -dist: qemu-$(VERSION).tar.bz2
> +dist: qemu-$(VERSION).tar.xz
>  
> -qemu-%.tar.bz2:
> -	$(SRC_PATH)/scripts/make-release "$(SRC_PATH)" "$(patsubst qemu-%.tar.bz2,%,$@)"
> +qemu-%.tar.xz:
> +	$(SRC_PATH)/scripts/make-release "$(SRC_PATH)" "$(patsubst qemu-%.tar.xz,%,$@)"
>  
>  distclean: clean
>  	rm -f config-host.mak config-host.h* config-host.ld $(DOCS) qemu-options.texi qemu-img-cmds.texi qemu-monitor.texi
> diff --git a/scripts/make-release b/scripts/make-release
> index 196c755..2237afd 100755
> --- a/scripts/make-release
> +++ b/scripts/make-release
> @@ -20,5 +20,5 @@ git checkout "v${version}"
>  git submodule update --init
>  rm -rf .git roms/*/.git
>  popd
> -tar cfj ${destination}.tar.bz2 ${destination}
> +XZ_OPT=-9 tar cfJ ${destination}.tar.xz ${destination}
>  rm -rf ${destination}
> -- 
> 1.7.6
>
>
> -- 
> This message has been scanned for viruses and
> dangerous content by MailScanner, and is
> believed to be clean.