From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44172) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TiDvm-0004g6-S3 for qemu-devel@nongnu.org; Mon, 10 Dec 2012 19:42:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TiDvl-0002GB-NI for qemu-devel@nongnu.org; Mon, 10 Dec 2012 19:42:42 -0500 Received: from ozlabs.org ([203.10.76.45]:54427) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TiDvl-0002G6-CR for qemu-devel@nongnu.org; Mon, 10 Dec 2012 19:42:41 -0500 From: Rusty Russell In-Reply-To: <1355149790-8125-4-git-send-email-aliguori@us.ibm.com> References: <1355149790-8125-1-git-send-email-aliguori@us.ibm.com> <1355149790-8125-4-git-send-email-aliguori@us.ibm.com> Date: Tue, 11 Dec 2012 11:02:14 +1030 Message-ID: <87d2yhcttd.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 3/4] virtio: modify savevm to have a stable wire format List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori , qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , David Gibson Anthony Liguori writes: > We were memcpy()'ing a structure to the wire :-/ Since savevm really > only works on x86 today, lets just declare that this element is sent > over the wire as a little endian value in order to fix the bitness. > > Unfortunately, we also send raw pointers and size_t which are going > to be different values on a 32-bit vs. 64-bit QEMU so we need to also > deal with that case. > > A lot of values that should have been previously ignored are now sent > as 0 and ignored on the receive side too. Don't we want to transition to vmstate anyway? Can we just do that, and relegate the existing slightly broken code, to legacy? Cheers, Rusty.