All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Anholt <eric@anholt.net>
To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: Kill i915_gem_execbuffer_wait_for_flips()
Date: Wed, 31 Oct 2012 17:18:47 -0700	[thread overview]
Message-ID: <87d2zy89aw.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <1351705121-17627-2-git-send-email-ville.syrjala@linux.intel.com>


[-- Attachment #1.1: Type: text/plain, Size: 715 bytes --]

ville.syrjala@linux.intel.com writes:

> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> As per Chris Wilson's suggestion make
> i915_gem_execbuffer_wait_for_flips() go away.
>
> This was used to stall the GPU ring while there are pending
> page flips involving the relevant BO. Ie. while the BO is still
> being scanned out by the display controller.
>
> The recommended alternative is to use the page flip events to
> wait for the page flips to fully complete before reusing the BO
> of the old front buffer. Or use more buffers.

So, after this change, if userland submits an execbuf between having
requested a pageflip and the vblank that the flip shows up on, does that
exec block?

[-- Attachment #1.2: Type: application/pgp-signature, Size: 197 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2012-11-01  0:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-31 17:38 [PATCH 0/2] drm/i915: Page flip stuff ville.syrjala
2012-10-31 17:38 ` [PATCH 1/2] drm/i915: Kill i915_gem_execbuffer_wait_for_flips() ville.syrjala
2012-10-31 19:17   ` Ville Syrjälä
2012-11-01  0:18   ` Eric Anholt [this message]
2012-11-01  8:58     ` Chris Wilson
2012-10-31 17:38 ` [PATCH 2/2] drm/i915: Wait for pending flips in intel_pipe_set_base() ville.syrjala
2012-10-31 17:43   ` Chris Wilson
2012-10-31 18:17     ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d2zy89aw.fsf@eliezer.anholt.net \
    --to=eric@anholt.net \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.