From: Rusty Russell <rusty@rustcorp.com.au>
To: Dave Jones <davej@redhat.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: virtio build breakage.
Date: Sat, 06 Oct 2012 17:04:31 +0930 [thread overview]
Message-ID: <87d30wyry0.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20121004225943.GA32483@redhat.com>
Dave Jones <davej@redhat.com> writes:
> After linking, I see this..
>
> ERROR: "virtqueue_kick" [net/9p/9pnet_virtio.ko] undefined!
> ERROR: "virtqueue_get_buf" [net/9p/9pnet_virtio.ko] undefined!
Cool!
Someone else spotted this recently, and the fix is in my recent pull
request to Linus:
commit 04679f34c141a0591e525d392929efc249440a7c
Author: Michael S. Tsirkin <mst@redhat.com>
Date: Fri Sep 28 15:05:14 2012 +0930
virtio-balloon: dependency fix
Devices should depend on virtio, not select it. It's supposed to be
selected by the particular driver, e.g. VIRTIO_PCI.
Make balloon depend on VIRTIO and EXPERIMENTAL
(to match description).
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
index f38b17a..271be80 100644
--- a/drivers/virtio/Kconfig
+++ b/drivers/virtio/Kconfig
@@ -27,8 +27,7 @@ config VIRTIO_PCI
config VIRTIO_BALLOON
tristate "Virtio balloon driver (EXPERIMENTAL)"
- select VIRTIO
- select VIRTIO_RING
+ depends on EXPERIMENTAL && VIRTIO
---help---
This driver supports increasing and decreasing the amount
of memory within a KVM guest.
prev parent reply other threads:[~2012-10-06 7:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-04 22:59 virtio build breakage Dave Jones
2012-10-06 7:34 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d30wyry0.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.