From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Ball Subject: Re: [PATCH] mmc: Report failure reasons for all cases in sdhci_add_host() Date: Tue, 03 Jul 2012 20:29:55 -0400 Message-ID: <87d34c74ho.fsf@octavius.laptop.org> References: <1341235575-17553-1-git-send-email-broonie@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from void.printf.net ([89.145.121.20]:50785 "EHLO void.printf.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751754Ab2GDA37 (ORCPT ); Tue, 3 Jul 2012 20:29:59 -0400 In-Reply-To: <1341235575-17553-1-git-send-email-broonie@opensource.wolfsonmicro.com> (Mark Brown's message of "Mon, 2 Jul 2012 14:26:15 +0100") Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Mark Brown Cc: linux-mmc@vger.kernel.org Hi, On Mon, Jul 02 2012, Mark Brown wrote: > For most error conditions sdhci_add_host() will print a diagnostic > message indicating why it failed but there are a few cases where this > does not happen. Add error messages in these cases to aid diagnosis. > > Signed-off-by: Mark Brown > --- > drivers/mmc/host/sdhci.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c > index caba999..acbc420 100644 > --- a/drivers/mmc/host/sdhci.c > +++ b/drivers/mmc/host/sdhci.c > @@ -3031,8 +3031,11 @@ int sdhci_add_host(struct sdhci_host *host) > > ret = request_irq(host->irq, sdhci_irq, IRQF_SHARED, > mmc_hostname(mmc), host); > - if (ret) > + if (ret) { > + pr_err("%s: Failed to request IRQ %d: %d\n", > + mmc_hostname(mmc), host->irq, ret); > goto untasklet; > + } > > sdhci_init(host, 0); > > @@ -3049,8 +3052,11 @@ int sdhci_add_host(struct sdhci_host *host) > host->led.brightness_set = sdhci_led_control; > > ret = led_classdev_register(mmc_dev(mmc), &host->led); > - if (ret) > + if (ret) { > + pr_err("%s: Failed to register LED device: %d\n", > + mmc_hostname(mmc), ret); > goto reset; > + } > #endif > > mmiowb(); Thanks, pushed to mmc-next for 3.6. - Chris. -- Chris Ball One Laptop Per Child