From: Thomas Rast <trast@inf.ethz.ch>
To: Junio C Hamano <gitster@pobox.com>
Cc: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>,
git@vger.kernel.org, "Bert Wesarg" <bert.wesarg@googlemail.com>,
"Geoffrey Irving" <irving@naml.us>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Pierre Habouzit" <madcoder@debian.org>
Subject: Re: [PATCH 2/3] parse-options: allow positivation of options starting, with no-
Date: Mon, 27 Feb 2012 09:30:09 +0100 [thread overview]
Message-ID: <87d390smpa.fsf@thomas.inf.ethz.ch> (raw)
In-Reply-To: <7vy5rpcgrk.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Sun, 26 Feb 2012 15:32:47 -0800")
Junio C Hamano <gitster@pobox.com> writes:
> I would naïvely expect that it would be sufficient to update an existing
> definition for "--no-frotz" that uses PARSE_OPT_NONEG to instead define
> "--frotz" that by itself is a no-op, and "--no-frotz" would cause whatever
> the option currently means, with an update to the help text that says
> something to the effect that "--frotz by itself is meaningless and is
> always used as --no-frotz".
Doesn't that last quote already answer your question? It would be
rather awkward to see, in 'git apply -h',
--add Also apply additions in the patch. This is the
default; use --no-add to disable it.
Compare to the current concise wording
--no-add ignore additions made by the patch
which lists the main (or mainly used) form in the left column, and
doesn't have to implicitly mention the 'no-' convention again to make
the help display useful.
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2012-02-27 8:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-25 19:07 [PATCH 0/3] parse-options: no- symmetry René Scharfe
2012-02-25 19:11 ` [PATCH 1/3] test-parse-options: convert to OPT_BOOL() René Scharfe
2012-02-25 19:14 ` [PATCH 2/3] parse-options: allow positivation of options starting, with no- René Scharfe
2012-02-26 23:32 ` Junio C Hamano
2012-02-27 8:30 ` Thomas Rast [this message]
2012-02-27 17:18 ` Junio C Hamano
2012-02-27 17:56 ` René Scharfe
2012-02-27 20:48 ` Junio C Hamano
2012-02-28 20:12 ` [PATCH 4/3] parse-options: disallow --no-no-sth René Scharfe
2012-02-28 21:15 ` Junio C Hamano
2012-02-29 18:06 ` René Scharfe
2012-02-29 19:02 ` Junio C Hamano
2012-02-25 19:15 ` [PATCH 3/3] parse-options: remove PARSE_OPT_NEGHELP René Scharfe
2012-02-27 18:25 ` Jeff King
2012-02-27 18:58 ` Junio C Hamano
2012-02-27 22:26 ` René Scharfe
2012-02-28 0:34 ` Jeff King
2012-02-28 19:06 ` [PATCH 3/3 v2] " René Scharfe
2012-02-28 19:09 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d390smpa.fsf@thomas.inf.ethz.ch \
--to=trast@inf.ethz.ch \
--cc=Johannes.Schindelin@gmx.de \
--cc=bert.wesarg@googlemail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=irving@naml.us \
--cc=madcoder@debian.org \
--cc=rene.scharfe@lsrfire.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.