From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Anholt <eric@anholt.net>
Subject: Re: [PATCH 1/2] drm/i915: Remove the MI_FLUSH_ENABLE
	setting.
Date: Fri, 20 Jan 2012 16:40:15 -0800
Message-ID: <87d3adkhw0.fsf@eliezer.anholt.net>
References: <1326999006-15100-1-git-send-email-eric@anholt.net>
	<86aa5jcylz.fsf@sumi.keithp.com> <4F18682D.9040909@bwidawsk.net>
	<87ty3qnq0v.fsf@eliezer.anholt.net> <4F19F168.1080506@bwidawsk.net>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0147702442=="
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
In-Reply-To: <4F19F168.1080506@bwidawsk.net>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

--===============0147702442==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Fri, 20 Jan 2012 14:57:44 -0800, Ben Widawsky <ben@bwidawsk.net> wrote:
> On 01/20/2012 11:16 AM, Eric Anholt wrote:
> > On Thu, 19 Jan 2012 10:59:57 -0800, Ben Widawsky <ben@bwidawsk.net> wro=
te:
> >> On 01/19/2012 10:54 AM, Keith Packard wrote:
> >>> On Thu, 19 Jan 2012 10:50:05 -0800, Eric Anholt <eric@anholt.net> wro=
te:
> >>>
> >>>> -		if (IS_GEN6(dev) || IS_GEN7(dev))
> >>>> -			mode |=3D MI_FLUSH_ENABLE << 16 | MI_FLUSH_ENABLE;
> >>>
> >>> This seems better than setting random bits that don't do anything but
> >>> annoy the simulator.
> >>
> >> The simulator complains unless both bits are set iirc. I can double
> >> check, but it's been a while since I've run without my patch.
> >=20
> > Can you please cite the message you're getting?  I've read a lot of the
> > simulator at this point, particularly pieces relating to flushing, and I
> > can't find what you're talking about.
> >=20
>=20
> It is not email friendly paste.
>=20
> Gen7GT/Render/src/CsMiCommonCatcher.cpp +293
>=20
> It links to a power point which shows the workaround is to set both
> bits. The powerpoint is kind enough to crash libreoffice for me.

That block is checking exactly one bit, bit 12, in my tree.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk8aCW8ACgkQHUdvYGzw6vcxmACePMkvM95oZFvygXBZNNOL6ep1
v1EAn1xHEKn66pwy2Yb8g2qhRZBZEkXo
=YrfD
-----END PGP SIGNATURE-----
--=-=-=--

--===============0147702442==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--===============0147702442==--