From: Kevin Hilman <khilman@ti.com>
To: Jean Pihet <jean.pihet@newoldbits.com>
Cc: balbi@ti.com,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
paul@pwsan.com, rjw@sisk.pl, Jean Pihet <j-pihet@ti.com>
Subject: Re: [PATCH 25/26] OMAP: PM: convert the SmartReflex code into the AVS driver framework
Date: Wed, 11 Jan 2012 16:52:17 -0800 [thread overview]
Message-ID: <87d3apvj26.fsf@ti.com> (raw)
In-Reply-To: <CAORVsuUio6viQxBFJES0wm7sP3O44se0CsiXue95XEKiR5_F4w@mail.gmail.com> (Jean Pihet's message of "Wed, 23 Nov 2011 12:30:54 +0100")
Jean Pihet <jean.pihet@newoldbits.com> writes:
>> if you already decide in runtime the correct initialization to call, why
>> do you add ifdefs ?
>
> There is no #ifdef with CONFIG_POWER_AVS_OMAP_V[12], those options are
> used to compile or not the respective modules, cf.
> driver/power/avs/Makefile.
I'd suggest not even having user-selectable Kconfig for this.
Just have a single Kconfig for POWER_AVS, then have
config POWER_AVS_OMAP
default PM && (ARCH_OMAP3 || ARCH_OMAP4)
which compiles both versions of the OMAP IP.
Kevin
next prev parent reply other threads:[~2012-01-12 0:52 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 15:05 [RFC/PATCH 00/26] PM: Create the AVS class of drivers jean.pihet
2011-11-22 15:05 ` [PATCH 01/26] OMAP2+: smartreflex: use sane default values jean.pihet
2011-11-22 15:05 ` [PATCH 02/26] OMAP3/4: SmartReflex: class drivers should use struct omap_sr * jean.pihet
2011-11-22 15:05 ` [PATCH 03/26] OMAP3/4: SmartReflex: API should use struct omap_sr *, not struct voltagedomain * jean.pihet
2011-11-22 15:05 ` [PATCH 04/26] OMAP: SmartReflex: drop _sr_lookup() jean.pihet
2011-11-22 15:05 ` [PATCH 05/26] OMAP: hwmod/SmartReflex: remove IP block instance-specific data from the driver code jean.pihet
2011-11-22 15:05 ` [PATCH 06/26] OMAP3+: Pass SmartReflex instance-specific data via hwmod dev_attr jean.pihet
2011-11-22 15:05 ` [PATCH 07/26] OMAP3+: hwmod: get rid of vdd_name field jean.pihet
2011-11-22 15:05 ` [PATCH 08/26] OMAP: SmartReflex: make pdata distinct from other data jean.pihet
2011-11-22 15:05 ` [PATCH 09/26] OMAP: SmartReflex: Use 'sr' for struct smartreflex jean.pihet
2011-11-22 15:05 ` [PATCH 10/26] OMAP2+: rename struct omap_sr_class_data to smartreflex_class_data jean.pihet
2011-11-22 15:05 ` [PATCH 11/26] OMAP3+: SmartReflex: remove unused PMIC code jean.pihet
2011-11-22 15:05 ` [PATCH 12/26] OMAP: SmartReflex: remove some SoC-specific implementation details from driver jean.pihet
2011-11-22 15:05 ` [PATCH 13/26] OMAP: SmartReflex driver interface: allow core to override eFuse data jean.pihet
2011-11-22 15:05 ` [PATCH 14/26] OMAP2+: Use the names from the SmartReflex data instead of voltage domains jean.pihet
2011-11-22 15:05 ` [PATCH 15/26] OMAP2+: SmartReflex: rename nvalue table jean.pihet
2011-11-22 15:06 ` [PATCH 16/26] OMAP2+: SmartReflex: cosmetic changes jean.pihet
2011-11-22 15:06 ` [PATCH 17/26] OMAP3+: Add SmartReflex clocks jean.pihet
2011-11-22 15:06 ` [PATCH 18/26] OMAP2+: Use the TRM formula to calculate the SmartReflex clock rate jean.pihet
2011-11-22 15:06 ` [PATCH 19/26] OMAP2+: SmartReflex: Remove the notifier handler jean.pihet
2011-11-22 15:06 ` [PATCH 20/26] OMAP2+: SmartReflex: make driver generic jean.pihet
2011-11-22 15:06 ` [PATCH 21/26] OMAP2+: SmartReflex: get rid of superfluous data that is duplicated between platform_data and the struct omap_sr jean.pihet
2011-11-22 15:06 ` [PATCH 22/26] OMAP2+: SmartReflex: remove OMAP specific code jean.pihet
2011-11-22 15:06 ` [PATCH 23/26] OMAP2+: SmartReflex: conversion into generic driver jean.pihet
2011-11-22 15:06 ` [PATCH 24/26] OMAP3+: voltage: export functions to plat/voltage.h jean.pihet
2011-11-22 15:06 ` [PATCH 25/26] OMAP: PM: convert the SmartReflex code into the AVS driver framework jean.pihet
2011-11-23 9:51 ` Felipe Balbi
2011-11-23 10:22 ` Jean Pihet
2011-11-23 11:04 ` Felipe Balbi
2011-11-23 11:30 ` Jean Pihet
2011-11-23 11:38 ` Felipe Balbi
2012-01-12 0:52 ` Kevin Hilman [this message]
2012-01-12 11:13 ` Jean Pihet
2011-11-23 23:34 ` Todd Poynor
2012-01-12 0:55 ` Kevin Hilman
2012-01-12 11:12 ` Jean Pihet
2011-11-22 15:06 ` [PATCH 26/26] PM: Create the AVS class of drivers jean.pihet
2011-11-22 16:43 ` [RFC/PATCH 00/26] " Mark Brown
2011-11-22 17:40 ` Cousson, Benoit
2011-11-22 17:47 ` Mark Brown
2011-11-22 20:01 ` Jean Pihet
[not found] ` <87mx9tu3x5.fsf@ti.com>
2012-01-12 1:06 ` Kevin Hilman
2012-01-12 11:17 ` Jean Pihet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d3apvj26.fsf@ti.com \
--to=khilman@ti.com \
--cc=balbi@ti.com \
--cc=j-pihet@ti.com \
--cc=jean.pihet@newoldbits.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.