From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH 00/24 V2] OMAP4: PM: suspend, CPU-hotplug and CPUilde support Date: Fri, 07 Oct 2011 15:35:13 -0700 Message-ID: <87d3e8juqm.fsf@ti.com> References: <1316844884-21700-1-git-send-email-santosh.shilimkar@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from na3sys009aog124.obsmtp.com ([74.125.149.151]:59542 "EHLO na3sys009aog124.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758737Ab1JGWfR (ORCPT ); Fri, 7 Oct 2011 18:35:17 -0400 Received: by mail-yw0-f53.google.com with SMTP id 2so4618201ywt.12 for ; Fri, 07 Oct 2011 15:35:16 -0700 (PDT) In-Reply-To: <1316844884-21700-1-git-send-email-santosh.shilimkar@ti.com> (Santosh Shilimkar's message of "Sat, 24 Sep 2011 11:44:20 +0530") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Santosh Shilimkar Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Hi Santosh, Santosh Shilimkar writes: > The series adds OMAP4 MPUSS (MPU SubSystem) power management support for > suspend (S2R), CPU hotplug and CPUidle. Just noticed when doing some final build/sanity testing that there are a few of compile/link warnings/problems when the kernel is built without CONFIG_PM Some warnings: /work/kernel/omap/pm/arch/arm/mach-omap2/omap-wakeupgen.c:203:13: warning: 'irq_save_context' defined but not used /work/kernel/omap/pm/arch/arm/mach-omap2/omap-wakeupgen.c:270:13: warning: 'irq_save_secure_context' defined but not used and some failures (these happen when CONFIG_SUSPEND=n but CONFIG_PM_RUNTIME=y: arch/arm/mach-omap2/built-in.o: In function `skip_l2en': /work/kernel/omap/pm/arch/arm/mach-omap2/sleep44xx.S:323: undefined reference to `cpu_resume' arch/arm/mach-omap2/built-in.o: In function `omap_sram_idle': /work/kernel/omap/pm/arch/arm/mach-omap2/pm34xx.c:429: undefined reference to `cpu_suspend' arch/arm/mach-omap2/built-in.o: In function `skipl2reen': /work/kernel/omap/pm/arch/arm/mach-omap2/sleep34xx.S:534: undefined reference to `cpu_resume' arch/arm/mach-omap2/built-in.o: In function `omap4_enter_lowpower': /work/kernel/omap/pm/arch/arm/mach-omap2/omap-mpuss-lowpower.c:281: undefined reference to `cpu_suspend' Turns out these are not directly related to your series and OMAP3 exhibits the same problems. I just posted a patch[1] to attempt to address these. But could you fixup the first problem and test with [1] to see if things still build/work as expected. Thanks, Kevin [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2011-October/068606.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@ti.com (Kevin Hilman) Date: Fri, 07 Oct 2011 15:35:13 -0700 Subject: [PATCH 00/24 V2] OMAP4: PM: suspend, CPU-hotplug and CPUilde support In-Reply-To: <1316844884-21700-1-git-send-email-santosh.shilimkar@ti.com> (Santosh Shilimkar's message of "Sat, 24 Sep 2011 11:44:20 +0530") References: <1316844884-21700-1-git-send-email-santosh.shilimkar@ti.com> Message-ID: <87d3e8juqm.fsf@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Santosh, Santosh Shilimkar writes: > The series adds OMAP4 MPUSS (MPU SubSystem) power management support for > suspend (S2R), CPU hotplug and CPUidle. Just noticed when doing some final build/sanity testing that there are a few of compile/link warnings/problems when the kernel is built without CONFIG_PM Some warnings: /work/kernel/omap/pm/arch/arm/mach-omap2/omap-wakeupgen.c:203:13: warning: 'irq_save_context' defined but not used /work/kernel/omap/pm/arch/arm/mach-omap2/omap-wakeupgen.c:270:13: warning: 'irq_save_secure_context' defined but not used and some failures (these happen when CONFIG_SUSPEND=n but CONFIG_PM_RUNTIME=y: arch/arm/mach-omap2/built-in.o: In function `skip_l2en': /work/kernel/omap/pm/arch/arm/mach-omap2/sleep44xx.S:323: undefined reference to `cpu_resume' arch/arm/mach-omap2/built-in.o: In function `omap_sram_idle': /work/kernel/omap/pm/arch/arm/mach-omap2/pm34xx.c:429: undefined reference to `cpu_suspend' arch/arm/mach-omap2/built-in.o: In function `skipl2reen': /work/kernel/omap/pm/arch/arm/mach-omap2/sleep34xx.S:534: undefined reference to `cpu_resume' arch/arm/mach-omap2/built-in.o: In function `omap4_enter_lowpower': /work/kernel/omap/pm/arch/arm/mach-omap2/omap-mpuss-lowpower.c:281: undefined reference to `cpu_suspend' Turns out these are not directly related to your series and OMAP3 exhibits the same problems. I just posted a patch[1] to attempt to address these. But could you fixup the first problem and test with [1] to see if things still build/work as expected. Thanks, Kevin [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2011-October/068606.html