All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@ti.com>
To: Balaji T K <balajitk@ti.com>
Cc: linux-omap@vger.kernel.org, linux-mmc@vger.kernel.org,
	cjb@laptop.org, tony@atomide.com, madhu.cr@ti.com,
	b-cousson@ti.com, paul@pwsan.com, kishore.kadiyala@ti.com
Subject: Re: [PATCHv3 2/3] MMC: OMAP: HSMMC: add runtime pm support
Date: Thu, 30 Jun 2011 16:23:12 -0700	[thread overview]
Message-ID: <87d3hudhun.fsf@ti.com> (raw)
In-Reply-To: <1309460700-25898-3-git-send-email-balajitk@ti.com> (Balaji T. K.'s message of "Fri, 1 Jul 2011 00:34:58 +0530")

Balaji T K <balajitk@ti.com> writes:

> add runtime pm support to HSMMC host controller
> Use runtime pm API to enable/disable HSMMC clock
> Use runtime autosuspend APIs to enable auto suspend delay
>
> Based on OMAP HSMMC runtime implementation by Kevin Hilman, Kishore Kadiyala
>
> Signed-off-by: Balaji T K <balajitk@ti.com>

Minor nit below...

[...]

> +static int omap_hsmmc_runtime_suspend(struct device *dev)
> +{
> +	struct omap_hsmmc_host *host;
> +
> +	host = platform_get_drvdata(to_platform_device(dev));
> +	omap_hsmmc_context_save(host);
> +	dev_dbg(mmc_dev(host->mmc), "disabled\n");
> +
> +	return 0;
> +}
> +
> +static int omap_hsmmc_runtime_resume(struct device *dev)
> +{
> +	struct omap_hsmmc_host *host;
> +
> +	host = platform_get_drvdata(to_platform_device(dev));
> +	omap_hsmmc_context_restore(host);
> +	dev_dbg(mmc_dev(host->mmc), "host: enabled\n");

Minor: this has a 'host: ' prefix, where as the one in
.runtime_suspend() does not. 

> +
> +	return 0;
> +}
> +

Kevin

  reply	other threads:[~2011-06-30 23:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-30 19:04 [PATCHv3 0/3] OMAP: HSMMC: cleanup and runtime pm Balaji T K
2011-06-30 19:04 ` [PATCHv3 1/3] MMC: OMAP: HSMMC: Remove lazy_disable Balaji T K
2011-06-30 19:04 ` [PATCHv3 2/3] MMC: OMAP: HSMMC: add runtime pm support Balaji T K
2011-06-30 23:23   ` Kevin Hilman [this message]
2011-07-01 16:05     ` T Krishnamoorthy, Balaji
2011-06-30 19:04 ` [PATCHv3 3/3] MMC: OMAP: HSMMC: Remove unused iclk Balaji T K
2011-06-30 19:36 ` [PATCHv3 0/3] OMAP: HSMMC: cleanup and runtime pm Cousson, Benoit
2011-07-01  6:16   ` T Krishnamoorthy, Balaji

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d3hudhun.fsf@ti.com \
    --to=khilman@ti.com \
    --cc=b-cousson@ti.com \
    --cc=balajitk@ti.com \
    --cc=cjb@laptop.org \
    --cc=kishore.kadiyala@ti.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=madhu.cr@ti.com \
    --cc=paul@pwsan.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.