Re: [PATCH 03/18] wl1251: fix scan behaviour while not associated

[Kalle Valo <kvalo@adurom.com>]

David Gnedt <david.gnedt@davizone.at> writes:

> With a dissacociated card I often encoutered very long scan delays.
>
> My guess is that it has something to do with the cards DTIM handling and
> another firmware bug mentioned in the TI WLAN driver, which is described as
> the card may never end scanning if the channel is overloaded because it
> can't send probe requests. I think the firmware somehow also tries to
> receive DTIM messages when the BSSID is not set. Therefore most of the time
> it waits for DTIM messages and can't do scanning work.
>
> Anyway we can workaround this misbehaviour by setting the HIGH_PRIORITY
> bit for scans in disassociated state.

Now that's a weird problem. I wonder this wasn't reported with the
fremantle kernels. How often did you see the problem?

> --- a/drivers/net/wireless/wl1251/cmd.c
> +++ b/drivers/net/wireless/wl1251/cmd.c
> @@ -419,7 +419,10 @@ int wl1251_cmd_scan(struct wl1251 *wl, u8 *ssid, size_t ssid_len,
>  	struct wl1251_cmd_scan *cmd;
>  	int i, ret = 0;
>  
> -	wl1251_debug(DEBUG_CMD, "cmd scan");
> +	wl1251_debug(DEBUG_CMD, "cmd scan channels %d ssid(%d) '%s'",
> +		     n_channels, ssid_len, ssid);

ssid is not a valid string and hence you cannot print it with %s.

> +	/*
> +	 * Use high priority scan when not associated to prevent fw issue
> +	 * causing never-ending scans (sometimes 20+ minutes).
> +	 * Note: This bug may be caused by the fw's DTIM handling.
> +	 */
> +	if (is_zero_ether_addr(wl->bssid))
> +		cmd->params.scan_options |= WL1251_SCAN_OPT_PRIORITY_HIGH;

Can you resend the patch with just this part and the accompanying
defines, please? It's better to have debug messages improvements in a
separate patch.

-- 
Kalle Valo