From: Ben Gamari <bgamari@gmail.com>
To: Bruno Randolf <br1@einfach.org>, Bob Copeland <me@bobcopeland.com>
Cc: linux-wireless@vger.kernel.org, ath5k-devel@lists.ath5k.org,
johannes@sipsolutions.net
Subject: Re: [PATCH/RFC 3/3] ath5k: trace resets
Date: Wed, 21 Jul 2010 01:46:22 -0400 [thread overview]
Message-ID: <87d3uhidzl.fsf@gmail.com> (raw)
In-Reply-To: <201007211417.23512.br1@einfach.org>
On Wed, 21 Jul 2010 14:17:23 +0900, Bruno Randolf <br1@einfach.org> wrote:
> but that's for all tracepoints all over the kernel... i think it's natural
> that this takes some CPU time. note that on these boards even the 22Mbps are
> limited by the CPU processing power.
>
The key word here is some. The numbers that you pointed out suggest that
the effect here is quite large. I find it hard to believe that something
isn't going wrong here. A single branch instruction really shouldn't be
this onerous unless it's in a fast path, in which case it should
probably be a compile-time option. What is the difference in image size
between kernels with and without tracing?
- Ben
next prev parent reply other threads:[~2010-07-21 5:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-17 19:35 [PATCH/RFC 0/3] ath5k: add driver tracepoints Bob Copeland
2010-07-17 19:35 ` [PATCH/RFC 1/3] ath5k: log descriptor chains at a new debug level Bob Copeland
2010-07-20 5:01 ` Bruno Randolf
2010-07-17 19:35 ` [PATCH/RFC 2/3] ath5k: use tracing for packet tx/rx dump Bob Copeland
2010-07-17 19:35 ` [PATCH/RFC 3/3] ath5k: trace resets Bob Copeland
2010-07-20 5:20 ` Bruno Randolf
2010-07-20 14:52 ` Bob Copeland
2010-07-21 1:04 ` Bruno Randolf
2010-07-21 1:12 ` [ath5k-devel] " Luis R. Rodriguez
2010-07-21 3:41 ` Bob Copeland
2010-07-21 5:17 ` Bruno Randolf
2010-07-21 5:46 ` Ben Gamari [this message]
2010-07-21 7:53 ` Johannes Berg
2010-07-22 9:21 ` Bruno Randolf
2010-07-20 5:11 ` [ath5k-devel] [PATCH/RFC 0/3] ath5k: add driver tracepoints Bruno Randolf
2010-07-20 7:54 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d3uhidzl.fsf@gmail.com \
--to=bgamari@gmail.com \
--cc=ath5k-devel@lists.ath5k.org \
--cc=br1@einfach.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=me@bobcopeland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.