From: Kevin Hilman <khilman@deeprootsystems.com>
To: Phil Carmody <ext-phil.2.carmody@nokia.com>
Cc: "Kauppi Ari (EXT-Ixonos/Oulu)" <ext-ari.kauppi@nokia.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"Kristo Tero (Nokia-D/Tampere)" <Tero.Kristo@nokia.com>
Subject: Re: [PATCH v2] OMAP3: PM: Add milliseconds interface to suspend wakeup timer
Date: Wed, 28 Apr 2010 11:51:18 -0700 [thread overview]
Message-ID: <87d3xje7h5.fsf@deeprootsystems.com> (raw)
In-Reply-To: <20100323083248.GA18857@pcarmody-desktop> (Phil Carmody's message of "Tue\, 23 Mar 2010 10\:32\:49 +0200")
Phil Carmody <ext-phil.2.carmody@nokia.com> writes:
> On 23/03/10 08:04 +0100, Kauppi Ari (EXT-Ixonos/Oulu) wrote:
>> Millisecond resolution is possible and there are use cases for it
>> (automatic testing).
>>
>> Seconds-based interface is preserved for compatibility.
>>
>> Signed-off-by: Ari Kauppi <Ext-Ari.Kauppi@nokia.com>
>>
>> ---
>> v2: Keep seconds and milliseconds interfaces strictly separate:
>> - Consistent interface, setting/getting seconds and milliseconds
>> is always accurate
>> - Fixes potential overflow issues in omap2_pm_wakeup_on_timer
>> - Cleaner patch
>
> Nice one. Just what we need, nothing more, nothing less.
>
> Reviewed-by: Phil Carmody <ext-phil.2.carmody@nokia.com>
>
Thanks, tested on omap3evm.
Pulling into PM branch queueing for 2.6.35.
Kevin
prev parent reply other threads:[~2010-04-28 18:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-22 8:10 [PATCH] OMAP3: PM: Modify suspend wakeup timer to use milliseconds instead of seconds Ari Kauppi
2010-03-22 17:10 ` Phil Carmody
2010-03-23 7:04 ` [PATCH v2] OMAP3: PM: Add milliseconds interface to suspend wakeup timer Ari Kauppi
2010-03-23 8:32 ` Phil Carmody
2010-04-28 18:51 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d3xje7h5.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=Tero.Kristo@nokia.com \
--cc=ext-ari.kauppi@nokia.com \
--cc=ext-phil.2.carmody@nokia.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.