From: Jed Brown <jed@59A2.org>
To: git@vger.kernel.org, Pierre Habouzit <madcoder@debian.org>
Subject: git send-email --notmuch expr
Date: Wed, 25 Nov 2009 03:49:59 +0100 [thread overview]
Message-ID: <87d4375ne0.fsf@59A2.org> (raw)
Notmuch is a new mail system with fast indexing and tagging, see
notmuchmail.org. It has a command-line tool to build replies to emails,
and I wrote a patch to format-patch that enables
git format-patch --notmuch EXPR
where EXPR is any notmuch query, but usually id:<Message-ID> to match a
specific message. This will set up several headers, notably
In-Reply-To, References, To, Cc, Bcc. This works great, and the the
patch follows this message.
But I really want
git send-email --notmuch EXPR
This sort-of works, but the interactive part prompts for the various
headers (even though format-patch supplies them), and then duplicates
the To header (both the possibly empty field the user provided, plus the
one coming from format-patch). I had a brief look at
git-send-email.perl, and I'm a little confused.
} elsif (/^(?:To|Cc|Bcc):/i) {
print "To/Cc/Bcc fields are not interpreted yet, they have been ignored\n";
next;
}
This regex doesn't match these headers (is the leading ?: a typo?) so
there is no warning. But it's important that these headers *not* be
ignored, getting them set automatically is a key feature of the
--notmuch option. I'm having trouble discerning whether I would cause
problems by just using these headers coming out of format-patch.
Presumably there was a reason why they were (intended to be) explicitly
ignored, and my poor perl skills are not helping. Could someone
enlighten me?
Jed
next reply other threads:[~2009-11-25 2:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-25 2:49 Jed Brown [this message]
2009-11-25 2:50 ` [PATCH 1/2] Added the --notmuch option to git format-patch Jed Brown
2009-11-25 2:50 ` [PATCH 2/2] Documentation for format-patch --notmuch Jed Brown
2009-11-25 10:16 ` git send-email --notmuch expr Jakub Narebski
2009-11-25 13:06 ` Jed Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d4375ne0.fsf@59A2.org \
--to=jed@59a2.org \
--cc=git@vger.kernel.org \
--cc=madcoder@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.