From: Kalle Valo <kalle.valo@iki.fi>
To: Julian Calaby <julian.calaby@gmail.com>
Cc: linville@tuxdriver.com, johannes@sipsolutions.net,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] mac80211: add ieee80211_rx_ni()
Date: Wed, 14 Oct 2009 10:18:14 +0300 [thread overview]
Message-ID: <87d44qo349.fsf@purkki.valot.fi> (raw)
In-Reply-To: <646765f40910132336m75799f8asb4328456f0f2e921@mail.gmail.com> (Julian Calaby's message of "Wed\, 14 Oct 2009 16\:36\:18 +1000")
Julian Calaby <julian.calaby@gmail.com> writes:
>>> You missed out ieee80211_rx_irqsafe() here.
>>
>> Here "this function" refer to ieee80211_rx_irqsafe(). But I can also
>> write it like this:
>>
>> Calls to ieee80211_rx_irqsafe(), ieee80211_rx() or ieee80211_rx_ni()
>> may not be mixed for a single hardware.
>>
>> Is that any better?
>
> Smacks self upside the head.
>
> This is what I get for commenting on patches in the morning.
>
> Sorry for the noise.
No problem at all, thank you for the review.
--
Kalle Valo
prev parent reply other threads:[~2009-10-14 7:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-13 17:33 [PATCH 1/2] mac80211: add ieee80211_rx_ni() Kalle Valo
2009-10-13 17:33 ` [PATCH 2/2] wl1251: use ieee80211_rx_ni() Kalle Valo
2009-10-13 22:33 ` [PATCH 1/2] mac80211: add ieee80211_rx_ni() Julian Calaby
2009-10-14 6:28 ` Kalle Valo
2009-10-14 6:36 ` Julian Calaby
2009-10-14 7:18 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d44qo349.fsf@purkki.valot.fi \
--to=kalle.valo@iki.fi \
--cc=johannes@sipsolutions.net \
--cc=julian.calaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.