From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH 4/4] ALSA: ASoC: Davinci: Fixed missing McBSP pinmux for SFFSDR Date: Tue, 10 Mar 2009 09:08:38 -0700 Message-ID: <87d4cptl6h.fsf@deeprootsystems.com> References: <1236655929-31688-1-git-send-email-hugo@hugovil.com> <1236655929-31688-5-git-send-email-hugo@hugovil.com> <20090310102921.GA12297@sirena.org.uk> <20090310100341.cc08cc08.hugo@hugovil.com> <20090310151615.GB12297@sirena.org.uk> <20090310114211.4ad49269.hugo@hugovil.com> <87hc21tlt1.fsf@deeprootsystems.com> <20090310160207.GE12297@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from wf-out-1314.google.com (wf-out-1314.google.com [209.85.200.175]) by alsa0.perex.cz (Postfix) with ESMTP id 7EA4C103872 for ; Tue, 10 Mar 2009 17:08:42 +0100 (CET) Received: by wf-out-1314.google.com with SMTP id 26so2490900wfd.23 for ; Tue, 10 Mar 2009 09:08:41 -0700 (PDT) In-Reply-To: <20090310160207.GE12297@sirena.org.uk> (Mark Brown's message of "Tue\, 10 Mar 2009 16\:02\:10 +0000") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: davinci-linux-open-source@linux.davincidsp.com, alsa-devel@alsa-project.org, Hugo Villeneuve List-Id: alsa-devel@alsa-project.org Mark Brown writes: > On Tue, Mar 10, 2009 at 08:55:06AM -0700, Kevin Hilman wrote: > >> On a related note, sound/soc/davinci/davinci-[evm,sffsdr].c is >> actually board-level setup code and should not actually live in >> sound/asoc/. It should live in arch/arm/mach-davinci/* and follow the >> rest of the davinci chip/board code upstream. > > No, the ASoC APIs are not stable enough for this - putting this code in > arch/arm will just lead to merge pain when code from one tree goes in > without updates from the other. > > Experience also suggests that audio drivers often get substantial enough > and need sufficient review to warrant keeping separate from the core > machine code. OK, good to know your opinion there. Thanks, Kevin