From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KQMGN-0001ee-36 for mharc-grub-devel@gnu.org; Tue, 05 Aug 2008 09:07:43 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KQMGK-0001ag-9A for grub-devel@gnu.org; Tue, 05 Aug 2008 09:07:40 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KQMGI-0001YS-L5 for grub-devel@gnu.org; Tue, 05 Aug 2008 09:07:39 -0400 Received: from [199.232.76.173] (port=41106 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KQMGI-0001Y5-FU for grub-devel@gnu.org; Tue, 05 Aug 2008 09:07:38 -0400 Received: from smtp-vbr11.xs4all.nl ([194.109.24.31]:2525) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KQMGH-0000yr-OE for grub-devel@gnu.org; Tue, 05 Aug 2008 09:07:38 -0400 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr11.xs4all.nl (8.13.8/8.13.8) with ESMTP id m75D7aSF003920 for ; Tue, 5 Aug 2008 15:07:37 +0200 (CEST) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <1217459965.26275.14.camel@fz-deb.local> <877ib1hvce.fsf@xs4all.nl> <20080801130222.GA12405@thorin> <87k5evhimz.fsf@xs4all.nl> <1217933393.7116.1.camel@fz.local> <1217936298.14245.0.camel@fz.local> Mail-Copies-To: mgerards@xs4all.nl Date: Tue, 05 Aug 2008 15:10:15 +0200 In-Reply-To: <1217936298.14245.0.camel@fz.local> (Felix Zielcke's message of "Tue, 05 Aug 2008 13:38:18 +0200") Message-ID: <87d4knehfs.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: [PATCH] skip over invalid BSD partitions X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Aug 2008 13:07:40 -0000 Felix Zielcke writes: > 2008-08-05 Felix Zielcke > > * partmap/pc.c (pc_partition_map_iterate): Do not abort on an invalid BSD > magic or if there's no space left, use grub_dprintf to issue a warning. Looks fine. > + { > + grub_dprintf ("partition", > + "invalid disk label magic 0x%x on partition %d\n" > + label.magic, p.index); > + continue; > + } Isn't a comma missing after the second string? I am surprised that this compiles. Or am I missing something? -- Marco