From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33)
	id 1C8cm2-0000bQ-3S
	for qemu-devel@nongnu.org; Sat, 18 Sep 2004 06:48:58 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33)
	id 1C8cm0-0000ag-2C
	for qemu-devel@nongnu.org; Sat, 18 Sep 2004 06:48:57 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.33) id 1C8cm0-0000ad-0W
	for qemu-devel@nongnu.org; Sat, 18 Sep 2004 06:48:56 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.34) id 1C8cg2-0002TP-2V
	for qemu-devel@nongnu.org; Sat, 18 Sep 2004 06:42:46 -0400
Received: from [195.122.192.2] (helo=janik.cz)
	by mx20.gnu.org with esmtp (Exim 4.34) id 1C8cV9-0003Kk-DP
	for qemu-devel@nongnu.org; Sat, 18 Sep 2004 06:31:31 -0400
From: Pavel@Janik.cz (=?iso-8859-2?q?Pavel_Jan=EDk?=)
Date: Sat, 18 Sep 2004 12:31:18 +0200
Message-ID: <87d60jhnrd.fsf@Janik.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-2
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] PATCH: uint32_t for pointer arithmetic?
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Hi,

oss.c is IMHO unnecessary retyping pointers to uint32_t and only after th=
at
to void *. This means that this will issue two warnings on 64bit platform=
s:

/home/pavel/QEMU/qemu-cvs/oss.c: In function `AUD_run':
/home/pavel/QEMU/qemu-cvs/oss.c:406: warning: cast from pointer to intege=
r of different size
/home/pavel/QEMU/qemu-cvs/oss.c:406: warning: cast to pointer from intege=
r of different size

--- oss.c.~1.5.~	2004-07-08 21:13:39.000000000 +0200
+++ oss.c	2004-09-18 12:23:57.017793080 +0200
@@ -403,7 +403,7 @@
=20
         left =3D oss.bufsize - oss.rpos;
         play =3D MIN (left, bytes);
-        written =3D write (oss.fd, (void *) ((uint32_t) oss.buf + oss.rp=
os), play);
+        written =3D write (oss.fd, (void *) (oss.buf + oss.rpos), play);
=20
         if (-1 =3D=3D written) {
             if (EAGAIN =3D=3D errno || EINTR =3D=3D errno) {

--=20
Pavel Jan=EDk

...... is one of the good guys, even though his user interface could stan=
d
improvement.
                  -- Larry McVoy in linux-kernel