From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mathieu Segaud Subject: Re: Bug report: slab error at module removal Date: Sun, 15 Aug 2004 22:01:06 +0200 Message-ID: <87d61sjhml.fsf@barad-dur.crans.org> References: <87pt5uibur.fsf@barad-dur.crans.org> <20040815161604.GB4703@backtop.namesys.com> Mime-Version: 1.0 Return-path: list-help: list-unsubscribe: list-post: Errors-To: flx@namesys.com In-Reply-To: <20040815161604.GB4703@backtop.namesys.com> (Alex Zarochentsev's message of "Sun, 15 Aug 2004 20:16:04 +0400") List-Id: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alex Zarochentsev Cc: reiserfs-list@namesys.com Alex Zarochentsev writes: > On Sat, Aug 14, 2004 at 06:26:36AM +0200, Mathieu Segaud wrote: >> slab error in kmem_cache_destroy(): cache `plugin_set': Can't free all objects >> [] kmem_cache_destroy+0xd1/0x130 >> [] plugin_set_done+0xa/0x30 [reiser4] >> [] shutdown_reiser4+0xf4/0x210 [reiser4] >> [] sys_delete_module+0x144/0x180 >> [] unmap_vma_list+0xe/0x20 >> [] do_munmap+0xef/0x150 >> [] sysenter_past_esp+0x52/0x71 This does not seem to fix every leak... I got the same message at module removal (this time the fs had been mounted, one of them was used to compile lirc, and each one was then umounted) > can you try the following patch: > > # This is a BitKeeper generated diff -Nru style patch. > # > # ChangeSet > # 2004/08/15 20:07:10+04:00 zam@crimson.namesys.com > # plugin_set_done: first clean the hash table and free all elements, then remove the slab cache. > # > # plugin/plugin_set.c > # 2004/08/15 20:07:07+04:00 zam@crimson.namesys.com +1 -1 > # plugin_set_done: first clean the hash table and free all elements, then remove the slab cache. > # > diff -Nru a/plugin/plugin_set.c b/plugin/plugin_set.c > --- a/plugin/plugin_set.c Sun Aug 15 20:12:29 2004 > +++ b/plugin/plugin_set.c Sun Aug 15 20:12:29 2004 > @@ -329,8 +329,8 @@ > reiser4_internal void plugin_set_done(void) > { > /* NOTE: scan hash table and recycle all objects. */ > - kmem_cache_destroy(plugin_set_slab); > ps_hash_done(&ps_table); > + kmem_cache_destroy(plugin_set_slab); > } > I forgot again to reenable DEBUG options. I will give it a try this night. -- Mathieu Segaud