From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] tiny patch for examples/Makefile (objcopy related)
Date: Wed, 10 Dec 2003 17:13:55 +0100 [thread overview]
Message-ID: <87d6awmz0c.fsf@deepthought.outer.space.org> (raw)
In-Reply-To: <20031207200513.42B50C5F5F@atlas.denx.de> (Wolfgang Denk's message of "Sun, 07 Dec 2003 21:05:08 +0100")
Hi Wolfgang & Cam,
> Dear Cam,
>
> in message <3FCDEA1B.6010306@mesias.co.uk> you wrote:
>>
>> Here is a short patch for the examples/Makefile. This improves
>> reliability in the case of a deficient toolchain.
>>
>> diff -urN u-boot-1.0.0.orig/examples/Makefile u-boot-1.0.0/examples/Makefile
>> --- u-boot-1.0.0.orig/examples/Makefile 2003-10-14 20:43:56.000000000 +0100
>> +++ u-boot-1.0.0/examples/Makefile 2003-12-03 11:21:04.000000000 +0000
>> @@ -104,7 +104,7 @@
>> $(OBJCOPY) -O srec $(<:.o=) $@
>>
>> %.bin: %.srec
>> - $(OBJCOPY) -O binary $< $@ 2>/dev/null
>> + $(OBJCOPY) -O binary $(<:.srec=) $@ 2>/dev/null
>>
>> #########################################################################
> Thanks, added.
Are you aware, that you effectively have a misleading rule now? The
rule says how to generate ".bin" from ".srec" files, while in the
command pattern you explicitely use none of the prerequisites but the
hand-derived ELF file. This might potentially mess up make's rule
algorithm.
As I am on holiday right now, I am too lazy to come up with a cleaner
fix, I just wanted to phrase my concern.
Cheers
Detlev
--
<ESC>:!emacs %
next prev parent reply other threads:[~2003-12-10 16:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-03 13:50 [U-Boot-Users] tiny patch for examples/Makefile (objcopy related) Cam
2003-12-03 15:32 ` George G. Davis
2003-12-07 20:05 ` Wolfgang Denk
2003-12-10 16:13 ` Detlev Zundel [this message]
2003-12-10 16:37 ` George G. Davis
2003-12-10 21:17 ` Cam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d6awmz0c.fsf@deepthought.outer.space.org \
--to=dzu@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.