All of lore.kernel.org
 help / color / mirror / Atom feed
From: Franck Baur <franck.baur.67@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>, netdev-bot+sashiko@kernel.org
Cc: cooldavid@cooldavid.org, andrew+netdev@lunn.ch,
	davem@davemloft.net, edumazet@kernel.org, pabeni@redhat.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH net] net: jme: keep RX MAC clock enabled for WoL
Date: Tue, 20 Oct 2026 12:57:04 +0200	[thread overview]
Message-ID: <87d73b29-945b-476b-ba02-71a5bad4b4bb@gmail.com> (raw)
In-Reply-To: <20261019182217.18e26e57@kernel.org>

Agreed, thanks for the review.

The RX MAC clock should be gated again after WoL is disabled on resume. 
I have added a call to jme_mac_rxclk_off() in jme_resume() to restore 
the expected clock state.

I have also addressed Sashiko's second concern regarding concurrent 
link-change work. The revised code prevents new link-change work from 
being scheduled and drains pending work before arming WoL during suspend 
and shutdown.

The revised driver object builds successfully with W=1. Runtime 
validation on the JMC250 rev 03 hardware is still pending.

I will complete the remaining tests before submitting v2 as a separate 
patch thread.

Thanks,
Franck

pw-bot: changes-requested


On 10/20/26 03:22, Jakub Kicinski wrote:
> On Mon, 12 Oct 2026 13:13:09 +0000 netdev-bot+sashiko@kernel.org wrote:
>> - [Medium] The patch turns the RX MAC clock on before arming WoL, but
>>    resume never turns it back off.
> sounds legit

      reply	other threads:[~2026-10-20 10:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-11 12:33 [PATCH net] net: jme: keep RX MAC clock enabled for WoL Franck BAUR via B4 Relay
2026-10-11 12:33 ` Franck BAUR
2026-10-12 13:13 ` netdev-bot+sashiko
2026-10-20  1:22   ` Jakub Kicinski
2026-10-20 10:57     ` Franck Baur [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d73b29-945b-476b-ba02-71a5bad4b4bb@gmail.com \
    --to=franck.baur.67@gmail.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=cooldavid@cooldavid.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev-bot+sashiko@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.