Re: [PATCH mptcp-next v3 2/3] Squash to "selftests/bpf: Add mptcp subflow subtest"

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang,

On 22/09/2024 03:00, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> Address Martin's comments:

Thank you for that!

> Drop mptcp_subflow__attach.
> Use bpf_program__attach_cgroup instead of bpf_prog_attach.
> Use the skel->links.{mptcp_subflow, _getsockopt_subflow}, instead of declaring a
> local "link".
> 
> More subflows for endpoint_init:
> 
> Add two more test addresses ADDR_3 and ADDR_4, and adds a new parameter
> "subflows" for endpoint_init() to control how many subflows are used for the
> tests. This makes it more flexible.

Should we not split that and keep it for later? I mean: I think it would
be better to only address Martin's comments, and modify endpoint_init()
later because this is not needed for the moment if I'm not mistaken.
When we will need more than 2 subflows, we can add these patches, no?

It's just to minimise the differences between the versions already
reviewed by Martin, and the future one. WDYT?

I can already apply patches 1 and 2/6 from your v2. Then check later
what is preferred before sending a new version upstream.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.