All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Sitnicki <jakub@cloudflare.com>
To: Ahmad Wicaksono <supersonix03@gmail.com>
Cc: bpf@vger.kernel.org,  rhkrqnwk98@gmail.com,  ast@kernel.org,
	daniel@iogearbox.net,  andrii@kernel.org,  eddyz87@gmail.com,
	memxor@gmail.com,  martin.lau@linux.dev,  song@kernel.org,
	yonghong.song@linux.dev,  jolsa@kernel.org,
	 john.fastabend@gmail.com, corbet@lwn.net,
	 linux-doc@vger.kernel.org
Subject: Re: [PATCH bpf-next 1/2] Documentation/bpf: Update sockmap docs for mutation restrictions
Date: Mon, 16 Nov 2026 19:51:05 +0100	[thread overview]
Message-ID: <87ecckr4o6.fsf@cloudflare.com> (raw)
In-Reply-To: <20261114170117.196552-2-supersonix03@gmail.com> (Ahmad Wicaksono's message of "Sun, 15 Nov 2026 00:01:16 +0700")

On Sun, Nov 15, 2026 at 12:01 AM +07, Ahmad Wicaksono wrote:
> Commit be39165224d0 ("bpf, sockmap: Disallow update and delete from tc,
> xdp, socket_filter and flow_dissector") dropped those program types from
> may_update_sockmap(), so tc, tc act, XDP, socket_filter and
> flow_dissector programs can no longer call bpf_map_update_elem() or
> bpf_map_delete_elem() on a sockmap or sockhash; the verifier now rejects
> them at load time with "cannot update sockmap in this context". The
> kernel-side sections of map_sockmap.rst did not mention this at all.
>
> Record which program types may still mutate these maps, and note that
> sock_ops programs may delete entries but have to use
> bpf_sock_map_update() or bpf_sock_hash_update() to add them.
>
> Also drop the reference to
> tools/testing/selftests/bpf/progs/test_sockmap_update.c and its link
> target. That file was removed by commit 5de7a6eaed89 ("selftests/bpf:
> Drop tc/xdp/flow_dissector/socket_filter sockmap mutation tests").
>
> Signed-off-by: Ahmad Wicaksono <supersonix03@gmail.com>
> ---

Reviewed-by: Jakub Sitnicki <jakub@cloudflare.com>

  reply	other threads:[~2026-11-16 18:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-14 17:01 [PATCH bpf-next 0/2] Documentation/bpf: Fix stale references in map docs Ahmad Wicaksono
2026-11-14 17:01 ` [PATCH bpf-next 1/2] Documentation/bpf: Update sockmap docs for mutation restrictions Ahmad Wicaksono
2026-11-16 18:51   ` Jakub Sitnicki [this message]
2026-11-17  5:10   ` Alexei Starovoitov
2026-11-14 17:01 ` [PATCH bpf-next 2/2] Documentation/bpf: Fix stale selftests file references Ahmad Wicaksono
2026-11-16 18:52   ` Jakub Sitnicki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ecckr4o6.fsf@cloudflare.com \
    --to=jakub@cloudflare.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=corbet@lwn.net \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=memxor@gmail.com \
    --cc=rhkrqnwk98@gmail.com \
    --cc=song@kernel.org \
    --cc=supersonix03@gmail.com \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.