All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Sreeraj S Kurup <sreekuttan2156239@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org,
	perex@perex.cz, tiwai@suse.de
Subject: Re: [PATCH v2] ALSA: compress: Set metadata_set only after successful callback
Date: Mon, 16 Nov 2026 12:29:45 +0100	[thread overview]
Message-ID: <87ecclypxy.wl-tiwai@suse.de> (raw)
In-Reply-To: <20261113092559.3283-1-sreekuttan2156239@gmail.com>

On Fri, 13 Nov 2026 10:25:59 +0100,
Sreeraj S Kurup wrote:
> 
> Set the metadata_set flag only when the driver's set_metadata()
> callback completes successfully.
> 
> Previously, the flag was set even when the callback returned an
> error. This incorrectly indicated that metadata had been applied
> successfully, potentially causing later operations to skip metadata
> setup.
> 
> Update the flag only when the callback returns zero so that its
> state accurately reflects successful metadata submission.
> 
> Fixes: 9727b490e543 ("ALSA: compress: add support for gapless playback")
> Signed-off-by: Sreeraj S Kurup <sreekuttan2156239@gmail.com>

Applied now.  Thanks.


Takashi

  reply	other threads:[~2026-11-16 11:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13  9:11 [PATCH] ALSA: compress: Set metadata_set only after successful callback Sreeraj S Kurup
2026-11-13  9:17 ` sashiko-bot
2026-11-13  9:25 ` [PATCH v2] " Sreeraj S Kurup
2026-11-16 11:29   ` Takashi Iwai [this message]
2026-11-16 13:59     ` Sreeraj S Kurup

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ecclypxy.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=sreekuttan2156239@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.