From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A618ECC6B1A for ; Wed, 14 Oct 2026 11:24:40 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xGx5w-0007Yl-Rt; Wed, 14 Oct 2026 07:24:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xGx5u-0007YK-Cu for qemu-riscv@nongnu.org; Wed, 14 Oct 2026 07:24:26 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xGx5s-0005dl-Il for qemu-riscv@nongnu.org; Wed, 14 Oct 2026 07:24:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1791977062; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ICxmSxA7fzkIRvEOP0m142eGhzSuJSs4m8P3Cr+XBi8=; b=ggPLD99saGUY4p16EAId3VKYnHw5Jv2rS90v32Gp53/8JI9jrmzPFgMTmgyRPdmnVW+dMi XLGCxB3jbfPZU7BNUwjxEqLrKwN4jamEl4huPkC78TJQaYj0xLDWMlDxgYIRPtDTqUv2Fs 6OknI46y//c6WJIqmqXW01DEiitLFec= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-283-1mBhQQ_JMR6L__uTmXAY1Q-1; Wed, 14 Oct 2026 11:24:21 +0000 X-MC-Unique: 1mBhQQ_JMR6L__uTmXAY1Q-1 X-Mimecast-MFC-AGG-ID: 1mBhQQ_JMR6L__uTmXAY1Q_1791977057 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BA247195606D; Wed, 14 Oct 2026 11:24:16 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.44.22.2]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 58FE41800446; Wed, 14 Oct 2026 11:24:15 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id EFC5F21E6A04; Wed, 14 Oct 2026 13:24:12 +0200 (CEST) From: Markus Armbruster To: Yonggang Luo Cc: qemu-devel@nongnu.org, Eric Blake , qemu-riscv@nongnu.org, Daniel P. =?utf-8?Q?Berrang=C3=A9?= , Alexander Bulekov , Laurent Vivier , Paolo Bonzini , Gerd Hoffmann , qemu-s390x@nongnu.org, Song Gao <17746591750@163.com>, Matthew Rosato , Alistair Francis , "Michael S. Tsirkin" , Fabiano Rosas , Eric Farman , Brian Cain , Stefan Hajnoczi , Darren Kenny , Ani Sinha , Peter Maydell , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Richard Henderson , Stafford Horne , Cornelia Huck , Zhao Liu , Weiwei Li , David Hildenbrand , Laurent Vivier , Pierrick Bouvier , Fam Zheng , "Edgar E. Iglesias" , Philippe =?utf-8?Q?Mathieu-Daud?= =?utf-8?Q?=C3=A9?= , Daniel Henrique Barboza , Palmer Dabbelt , qemu-arm@nongnu.org, Chao Liu , Philippe Mathieu-Daude , Jiaxun Yang , Max Filippov , Stefano Garzarella Subject: Re: [PATCH 04/34] qapi: rename SysEmuTarget to EmuTarget In-Reply-To: <20261014093152.834-5-luoyonggang@gmail.com> (Yonggang Luo's message of "Wed, 14 Oct 2026 17:31:14 +0800") References: <20261014093152.834-1-luoyonggang@gmail.com> <20261014093152.834-5-luoyonggang@gmail.com> Date: Wed, 14 Oct 2026 13:24:12 +0200 Message-ID: <87ecdscyoz.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-MFC-PROC-ID: ktirrX_5MfN4B089YWAVuSGAwiXSN_xghuoV0B9ELqU_1791977057 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 10 X-Spam_score: 1.0 X-Spam_bar: + X-Spam_report: (1.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.24, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org Sender: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org Yonggang Luo writes: > As now it's also expressing user-mode targets. > > This changes the type name exposed by query-qmp-schema; enum values and > serialized target values remain unchanged. Are you sure? query-qmp-schema masks the type names. > Signed-off-by: Yonggang Luo [...] > diff --git a/qapi/machine.json b/qapi/machine.json > index 9b145c635ba..07fac4f0764 100644 > --- a/qapi/machine.json > +++ b/qapi/machine.json > @@ -14,7 +14,7 @@ > { 'include': 'machine-common.json' } > > ## > -# @SysEmuTarget: > +# @EmuTarget: > # The comprehensive enumeration of QEMU system emulation > # ("softmmu") targets. Run "./configure --help" in the project > # root directory, and look for the \*-softmmu targets near the # "--target-list" option. The individual target constants are not # documented here, for the time being. Is this still correct? > @@ -35,7 +35,7 @@ > # > # Since: 3.0 > ## > -{ 'enum' : 'SysEmuTarget', > +{ 'enum' : 'EmuTarget', > 'data' : [ 'aarch64', 'alpha', 'arm', 'avr', 'hexagon', 'hppa', 'i386', > 'loongarch64', 'm68k', 'microblaze', 'mips', 'mips64', > 'mips64el', 'mipsel', 'or1k', 'ppc', > @@ -95,7 +95,7 @@ > 'qom-path' : 'str', > 'thread-id' : 'int', > '*props' : 'CpuInstanceProperties', > - 'target' : 'SysEmuTarget' }, > + 'target' : 'EmuTarget' }, > 'discriminator' : 'target', > 'data' : { 's390x' : 'CpuInfoS390' } } > > @@ -281,7 +281,7 @@ > # Since: 1.2 > ## > { 'struct': 'QemuTargetInfo', > - 'data': { 'arch': 'SysEmuTarget' } } > + 'data': { 'arch': 'EmuTarget' } } > > ## > # @query-target: > diff --git a/qapi/pragma.json b/qapi/pragma.json > index 342cedc42e7..93a710ee937 100644 > --- a/qapi/pragma.json > +++ b/qapi/pragma.json > @@ -72,7 +72,7 @@ > 'SsidSizeMode', > 'String', > 'StringWrapper', > - 'SysEmuTarget', > + 'EmuTarget', > 'ThrottleGroupProperties', > 'VncPrimaryAuth', > 'VncVencryptSubAuth', > @@ -109,7 +109,7 @@ > 'QKeyCode', # send-key, input-sent-event > 'QapiErrorClass', # QMP error replies > 'SshHostKeyCheckMode', # blockdev-add, -blockdev > - 'SysEmuTarget', # query-cpu-fast, query-target > + 'EmuTarget', # query-cpu-fast, query-target > 'UuidInfo', # query-uuid > 'VncClientInfo', # query-vnc, query-vnc-servers, ... > 'X86CPURegister32' # qom-get of x86 CPU properties [...]