From: Takashi Iwai <tiwai@suse.de>
To: Vadym Shevchuk <0xsheff@gmail.com>
Cc: Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
linux-sound@vger.kernel.org
Subject: Re: [PATCH v2] ALSA: usb-audio: Add quirk for Shanling UP4
Date: Mon, 05 Oct 2026 15:18:03 +0200 [thread overview]
Message-ID: <87ece4s2us.wl-tiwai@suse.de> (raw)
In-Reply-To: <20261005125953.190316-1-0xsheff@gmail.com>
On Mon, 05 Oct 2026 14:59:53 +0200,
Vadym Shevchuk wrote:
>
> The Shanling UP4 (0a12:1244, CSR-based, UAC1, full speed) sets the
> MaxPacketsOnly bit in its AS isochronous endpoint descriptor. With
> UAC_EP_CS_ATTR_FILL_MAX set, the driver fills every 1 ms packet up to
> wMaxPacketSize, i.e. 48 frames, regardless of the sample rate. At
> 44.1 kHz the device expects 44/45 frames per packet and outputs only
> silence. 48 kHz works because both packet sizes are the same there.
>
> Measured with aplay on hw:UP4,0, 4 s of S16_LE stereo:
>
> before: 44.1 kHz consumed at ~48030 frames/s, done in 3.68 s, silent
> after: 44.1 kHz consumed at ~44220 frames/s, done in 4.00 s, audible
>
> 48 kHz plays fine both before and after the change. Regular music
> playback at 44.1 kHz through PipeWire sounds fine as well.
>
> Clear the attribute for this device, as is already done for the MOTU
> MicroBook IIc. Since the packet sizes are equal at 48 kHz, this does
> not change anything for other devices that may share this CSR USB ID
> and only use 48 kHz.
>
> Link: https://lore.kernel.org/all/CAPHAwzdUNRbZjBQuYKLf18EK_QGq0gR6Vx3YMZ=ffYKBogUtLA@mail.gmail.com/
> Signed-off-by: Vadym Shevchuk <0xsheff@gmail.com>
Applied to for-next branch now. Thanks.
Takashi
prev parent reply other threads:[~2026-10-05 13:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAPHAwzdUNRbZjBQuYKLf18EK_QGq0gR6Vx3YMZ=ffYKBogUtLA@mail.gmail.com>
2026-10-03 9:13 ` [BUG] ALSA: usb-audio: Shanling UP4 (0a12:1244) silent at 44.1 kHz due to MaxPacketsOnly Takashi Iwai
2026-10-05 9:44 ` [PATCH] ALSA: usb-audio: Add quirk for Shanling UP4 Vadym S
2026-10-05 12:59 ` [PATCH v2] " Vadym Shevchuk
2026-10-05 13:18 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ece4s2us.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=0xsheff@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.